RTL Support

[Liam-Ryan]

Is it possible to switch the direction of the slider by setting a flag for right to left? I haven't been able to find anything in the documentation and switching floor and ceiling seems to work as far as calculating values but the sliders stay stuck at the rightmost extreme of the bar

[ValentinH]

Nope this is not currently possible but this could be a cool feature.

For now, you can do a work-around by using the stepsArray and showSelectionBarEnd like in this example: http://jsfiddle.net/hm9nntmm/

[Liam-Ryan]

Thanks I'll see if I can work it in easily at this stage. Would you mind
leaving this open and I'll see if I can put together a pull request in the
near future?

On Thu, Feb 18, 2016 at 9:55 AM, Valentin Hervieu notifications@github.com
wrote:

Nope this is not currently possible but this could be a cool feature.

For now, you can do a work-around by using the stepsArray and
showSelectionBarEnd like in this example: http://jsfiddle.net/hm9nntmm/

—
Reply to this email directly or view it on GitHub
#270 (comment)
.

[ValentinH]

Yes sure, I'd be glad to provide support for it if needed ;)

[Liam-Ryan]

I'm just starting to work on this feature, what approach would you recommend for quick testing and deployment? I notice grunt serve does not run the demo, is there a task that watches files and runs the demo?

[ValentinH]

grunt serve should serve the demo at localhost:9000/demo/index.html.
Then to test your new feature, simply add a block in the demo/index.html and demo.js.

[Liam-Ryan]

Hi Valentin,

I'm almost ready to commit a PR but I've noticed some differences in the code style in places

(I had code but the formatting wasn't preserved). In some areas the else of an if/else construct is on the following line, in others it's the same line

Can you let me know which is the preferred style for if/else blocks? Thanks

[ValentinH]

Good news! About the code style, there is an editor config file that can be automatically applied by using the corresponding plugin. Which editor are you using?

[Liam-Ryan]

I'm using Webstorm. I was about 60% through the unit tests and noticed some
of the mouse tests failing when using a range in RTL, it's allowing the min
or max to go below or above the floor/ceiling if you drag the entire bar
with a preset range. Do you know where in the code this is handled off the
top of your head?

Also is there a way that I can incrementally update my fork for feedback
without breaking the "use grunt commit" instruction in contributing.MD?

Thanks again

On Sun, Feb 21, 2016 at 9:10 AM, Valentin Hervieu notifications@github.com
wrote:

Good news! About the code style, there is an editor config file that can
be automatically applied by using the corresponding plugin. Which editor
are you using?

—
Reply to this email directly or view it on GitHub
#270 (comment)
.

[ValentinH]

The part that prevents from going above/below ceil/floor is here: https://github.com/angular-slider/angularjs-slider/blob/master/src/rzslider.js#L1416

About the commit, you should do the first one with npm run commit, and then you can do several other ones and just rebase/squash everything when the PR is ready to be merged.
You should already push a commit so I can tell you if you are going in a correct direction. ;)

[ValentinH]

About Webstorm, I'm using it too and there is a plugin that handles EditorConfig. Thanks to it, I simply press CMD+ALT+L to reformat everything.

[ValentinH]

Feature available in 2.10.X