Skip to content

[BUG] Running simpleperf report always requires Tk-Inter even if no gui report is requested #2135

@drott

Description

@drott

Description

Using simpleperf from Chromium using the scripts provided for the Chromium-built apk, the script at some points runs simpleperf. I believe to generate a perf.data style output, which is then converted to the proto format.

However, the step fails if python tk-inter is not installed. That does not seem necessary if the tool is not run in --gui mode.

I suggest to make the import in https://android.googlesource.com/platform/system/extras/+/refs/heads/main/simpleperf/scripts/report.py#34 dependent on which mode the tool is run in.

I am using a supported NDK

  • I have checked and the NDK I'm using is currently supported

Affected versions

r28

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions