This repository was archived by the owner on Nov 23, 2017. It is now read-only.
Add support for 2.0.0-preview #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added check for hadoop version. cc @thisisdhaas |
spark_ec2.py
Outdated
|
|
||
| if tachyon_v == "": | ||
| print("No valid Tachyon version found; Tachyon won't be set up") | ||
| modules = filter(lambda x: x != "tachyon", modules) |
There was a problem hiding this comment.
more pythonic is just modules.remove('tachyon')
|
code LGTM w/ a minor comment, I'm not the right person to validate your hadoop versioning logic. |
|
Thanks @thisisdhaas for taking a look. I tested this by launching a 3 node cluster and 2.0.0-preview came up fine. Merging this branch-2.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
There is one problem that is not addressed by this PR. Spark 2.0 and higher only support Hadoop 2.3.0 or higher and thus should also use hadoop_major_version as YARN in spark-ec2.