Skip to content

FEAT: Music Player UI Enhanced #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 6, 2020
Merged

FEAT: Music Player UI Enhanced #504

merged 18 commits into from
Jul 6, 2020

Conversation

@samarth30
Copy link
Contributor

@samarth30 samarth30 commented Jan 6, 2020

Enhancement Of UI

here i enhanced ui i turned the toolbar and the exo player background to transparent so that it will increase the user experience
Screenshot_2020-01-06-13-03-36-21_8f7f52555d974a92fa29728873f61978

Screenshot_2020-01-06-13-04-47-92_8f7f52555d974a92fa29728873f61978

Animation

here i also added animation when the player open so that it will too increase the user experience here i have used animatoo library the changes can be seen in the vdieo

asdf

phone details
my phone is oppo realme with updated android version 9.0 (nugget)

hope you will merge this pull request @cpg

@chirag-jn chirag-jn self-assigned this Jun 18, 2020
@chirag-jn
Copy link
Member

chirag-jn commented Jul 6, 2020 •
edited
Loading

Suggestion Needed: Do we need this change? @cpg

chirag-jn
chirag-jn reviewed Jul 6, 2020
View reviewed changes
src/main/AndroidManifest.xml Outdated
<uses-permission android:name="android.permission.USE_CREDENTIALS" />
<uses-permission android:name="android.permission.WAKE_LOCK" />
<uses-permission android:name="android.permission.WRITE_SETTINGS" />
<uses-permission android:name="android.permission.WRITE_SETTINGS"
Copy link
Member

@chirag-jn chirag-jn Jul 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring linting warnings in this way might not be the best thing to do.
Ref: https://riptutorial.com/android/example/1135/using-tools-ignore-in-xml-files

@chirag-jn
Copy link
Member

chirag-jn commented Jul 6, 2020

Too many things happening in this PR. You are handling permissions issue in this PR too which was happening in another PR at the same time. Ref: #501

@chirag-jn
Copy link
Member

chirag-jn commented Jul 6, 2020

@samarth30 this PR contains your code from all other PRs too which is very difficult to manage since a change in one PR will force to make changes in all other PRs of yours. Please check the same as this is leading to unnecessary conflicts.

@chirag-jn
Copy link
Member

chirag-jn commented Jul 6, 2020

Swipe Left animation goes against the app's theme of blink animation.

@chirag-jn chirag-jn added the on hold Hold on there, buddy! label Jul 6, 2020
@chirag-jn chirag-jn changed the title FEAT: MUSIC PLAYER UI ENHANCED And Added Animation FEAT: Music Player UI Enhanced Jul 6, 2020
@chirag-jn chirag-jn mentioned this pull request Jul 6, 2020
Closed
@cpg cpg merged commit 601914d into amahi:beta Jul 6, 2020
chirag-jn added a commit to chirag-jn/android that referenced this pull request Aug 1, 2020
@chirag-jn
Squashed commit of the following:
c59fcec 
commit a721c61
Author: Akash-Ramjyothi <[email protected]>
Date:   Wed Jul 29 21:22:02 2020 +0530

    Add Icons to Settings Activity (amahi#585)

    * Added Material Icons
    * Update Settings logos
    * reformat code

    Co-authored-by: Chirag Jain <[email protected]>

commit 7eab1ea
Author: Chirag Jain <[email protected]>
Date:   Wed Jul 29 17:07:51 2020 +0530

    Update minSDK version (amahi#583)

commit 2bd3f3b
Author: Chirag Jain <[email protected]>
Date:   Wed Jul 29 16:40:47 2020 +0530

    gitignore (amahi#581)

commit bbcf8cf
Author: Chirag Jain <[email protected]>
Date:   Wed Jul 29 16:40:15 2020 +0530

    update travis (amahi#578)

commit f252553
Author: Chirag Jain <[email protected]>
Date:   Wed Jul 29 16:39:27 2020 +0530

    Add Custom Tabs to WebView (amahi#573)

    * Add Custom Tabs to WebView
    * Add License and theme to CustomTabs

commit 6d1e357
Author: Chirag Jain <[email protected]>
Date:   Wed Jul 29 16:25:15 2020 +0530

    Add Repeat and Shuffle Feature to Music Player (amahi#576)

    * feat: music player shuffle and repeat features
    * clean code
    * enable multidex
    * Reset Exoplayer to 2.7
    * Update Multidex
    * remove multidex

    Co-authored-by: Balaji R <[email protected]>
    Co-authored-by: Carlos Puchol <[email protected]>

commit f3035ff
Author: Akash-Ramjyothi <[email protected]>
Date:   Wed Jul 29 16:09:34 2020 +0530

    Added Updates to libraries (amahi#580)

    * update libvlc version
    * Added Updates to libraries
    * Update build.gradle

    Co-authored-by: Chirag Jain <[email protected]>

commit f6f297b
Author: Akash-Ramjyothi <[email protected]>
Date:   Wed Jul 29 16:08:02 2020 +0530

    Added Last Display of Files Feature (amahi#574)

commit 761a34e
Author: Chirag Jain <[email protected]>
Date:   Mon Jul 20 16:48:31 2020 +0530

    Application Crash Reports (amahi#565)

    * Add ACRA for Crash Reporting during development

commit f0bf41f
Author: Chirag Jain <[email protected]>
Date:   Mon Jul 20 16:47:34 2020 +0530

    Update README with better badges (amahi#568)

    * Update README with badges

commit e7888e9
Author: Chirag Jain <[email protected]>
Date:   Sat Jul 18 01:27:41 2020 +0530

    Add release to gitignore (amahi#562)

commit 303f0df
Author: Chirag Jain <[email protected]>
Date:   Mon Jul 13 16:45:27 2020 +0530

    Fix App Not Loading (amahi#561)

commit adad44d
Author: Chirag Jain <[email protected]>
Date:   Tue Jul 7 15:59:50 2020 +0530

    App Introduction Improvements (amahi#555)

    * Move to AppIntro2
    * Optimize imports

commit 99e75d9
Author: Chirag Jain <[email protected]>
Date:   Mon Jul 6 17:07:31 2020 +0530

    Fix: Inform user if there's no internet connection while trying to access media files (amahi#553)

    * Fix: Inform user if there's no internet connection while trying to access files, also checks for local server connection
    * update strings
    * Toast -> Snackbar
    * update AppIntro

    Co-authored-by: Balaji R <[email protected]>

commit ac2d5eb
Author: Chirag Jain <[email protected]>
Date:   Mon Jul 6 16:55:47 2020 +0530

    Add Localization Support (amahi#545)

    * Add Locale Helper
    * Add language change preference
    * change language
    * Attach Base Context in Activities
    * remove extra dependency
    * Complete French translation
    * Add Steps to add language

commit 601914d
Author: samarth gugnani <[email protected]>
Date:   Mon Jul 6 16:48:11 2020 +0530

    FEAT: Music Player UI Enhanced (amahi#504)

    * Crash Solved Happening Due to lack Of Permissions and added dilogue box
    * Connection Error solved
    * fixed the connection error in apps navigation
    * Connection Error solved Final
    * UI Enhanced
    * reset new issue template
    * clean code
    * remove animatoo

    Co-authored-by: Chirag Jain <[email protected]>

commit 57e2008
Author: samarth gugnani <[email protected]>
Date:   Mon Jul 6 16:45:08 2020 +0530

    Crash Solved Due to Storage and camera Permissions and Added Dialogue box  (amahi#501)

    * Crash Solved Happing Due to lack Of Permissions
    * Crash Solved Happing Due to lack Of Permissions and added dilogue box
    * Crash Solved Happening Due to lack Of Permissions and added dilogue box
    * Reset new-issue.md
    * remove extra lines
    * rearrange code in ServerFilesActivity
    * reset setupuploadfab
    * clean code
    * change strings
    * Permissions issue handled
    * refactor serverfilesactivity
    * remove extra logs

    Co-authored-by: Chirag Jain <[email protected]>

commit 52667ef
Author: Balaji Ramavathu <[email protected]>
Date:   Mon Jul 6 16:39:36 2020 +0530

    fix: App crash after Sign out and Sign in again (amahi#440)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chirag-jn chirag-jn chirag-jn left review comments

Assignees

@chirag-jn chirag-jn

Labels

enhancement on hold Hold on there, buddy!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samarth30 @chirag-jn @cpg