changes in navigation drawer #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpg Does this drawer looks fine to you? To me it looks fine |
|
I thought we decided to call them "Downloaded" rather than "Offline files"? It looks great. i like the shares icon. the downloaded one is not too obvious, but it's nice. a small cell phone could be used |
octacode
pushed a commit
that referenced
this pull request
Aug 13, 2018
* fixes server loading issue (#378) (#379) * changes in navigation drawer (#380) * changes in navigation drawer * implements full height navigation drawer * fixes offline navigation issue (#377) * Offline feature improvements (#381) * handles error in downloading for offline files * separate notifications for each complete offline file download * Revert "Offline feature improvements (#381)" (#383) This reverts commit c545ac4. * adds support for recent files (#374) * adds recent files table * adds recent files activity and its dependencies * adds recent file actions * adds upload support for all types of file (#385) * Offline improvement (#384) * handles error in downloading for offline files * separate notifications for each complete offline file download * changes in name and icons * adds progress bar in offline activity * fixes server name issue * adds audio navigation (#387) * adds audio navigation * adds audio list * improvements in cast (#386) * adds local server login for secondary user * adds HDA cache * handling responses * restoring session apis and fixing auto upload setting * handles unauthorize response * changes in TV UI for pin access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the navigation drawer:
Changes remaining:
closes #365 #300 #377