-
Notifications
You must be signed in to change notification settings - Fork 12.1k
Migrate cv.yml to RenderCV schema #2969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Migrate cv.yml to RenderCV schema #2969
Conversation
✅ Deploy Preview for relaxed-lollipop-b6bc17 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
I think I can took a look at it tomorrow. |
Sorry for the delay. Just looked at your code and found a fix. |
1b280c3
to
df9198d
Compare
Just tried to create an action to validate the yml against the schema, but it is failing. But maybe is because this schema is valid only to be used inside code editors? |
The JSON Resume to RenderCV converter I was looking at was successfully using a different URL pointing to the same file to validate the schema. https://github.com/guruor/jsonresume-to-rendercv/blob/main/jsonresume_to_rendercv/converter.py It seems that a new version of RenderCV has been released a couple of days ago with some changes and this cv.yml does not follow the new schema. This could be causing the errors. |
df9198d
to
e0d31a5
Compare
Sorry for the delay. I have fixed the rendering issues and updated the schema. However, the issues with validating the schema using actions were not caused by the file not following the schema, as the old file was still following the schema as per my editor. The update to the schema only added new entries, which I wasn't using in the old file. |
Have you figured it out why is it failing the schema action? |
My guess is that it is some problem with the action itself, I will try some tests and see if it works. |
Maybe #3012 can also be tackled in this PR? Edit: forget it, I thought the problem was in CV, not in bibliography. |
Thanks @jiuntian, I'll take a look at this later. |
Thanks @george-gca While I trying to made this to work on my own website, I also notice another incorrect variable name that made the sorting in CV failed. Can check the following changes: |
RenderCV renders CV sections dynamically based on the entry type, as described in the RenderCV documentation.I believe we can adopt a similar approach, instead of hardcoding specific sections. This would eliminate the need to modify the layout whenever the user wish to add a new section, especially since we’re planning to use the RenderCV schema for cv.yml. I’ve implemented a dynamic layout for this project that renders CV sections based on the entry type defined by the RenderCV schema. Each entry type is detected by its mandatory fields and rendered using its own Liquid layout file. You can view the commit on my personal website here: jiuntian@a890996. This implemented all currently available entry types: EducationEntry, ExperienceEntry, PublicationEntry, NormalEntry, OneLineEntry, BulletEntry, and TextEntry. Let me know if you think this proposal is useful, we can discuss how best to integrate it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@jiuntian I think that your solution would be really useful. Are you still willing to submit a PR? |
@george-gca I’d be happy to submit a PR once I have the capacity. I’ll keep you posted! |
67de8fa
to
50f6b19
Compare
I see the point in using the native section system of RenderCV rather than imitating the JSONresume like i did. I will now push a workflow for auto generation of RenderCV PDF which can be integrated into your solution. As for the schema validation, the addition of #properties/design/required is one of the problems but there are many problems associated with it, such as a typo in the main code for section_title type, there is a type named "with-parial-line" instead of the type "with-partial-line" which is specified in the schema. Currently, using a local schema file with version lock of RenderCV in the workflows seems to be for the best. I will raise an issue on RenderCV repo to improve the schema in the meantime. |
The cv.yml will follow the RenderCV schema as the first step towards auto-generating CV PDFs from cv.yml or resume.json as discussed in #2787. The YAML file also supports markdown formatting to make it RenderCV friendly.
example_pdf.pdf updated to pdf generated by RenderCV using the example cv.yml file.
The existing cv.yml format would be deprecated after this PR.