Fixed loadContents in the collector step
#846
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #846 +/- ##
==========================================
+ Coverage 72.79% 72.81% +0.02%
==========================================
Files 90 90
Lines 12033 12033
Branches 2116 2116
==========================================
+ Hits 8759 8762 +3
+ Misses 2790 2787 -3
Partials 484 484 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Test added in common-workflow-language/cwl-v1.3/pull/77 |
LanderOtto
force-pushed
the
fix/collector-content
branch
2 times, most recently
from
29ccea2 to
4d87434
Compare
… executed directly and its output includes `loadContents`. Before to this fix, the `TokenProcessor` in the collector step incorrectly attempted to compute the content loading. However, this loading should only be handled by the `CommandOutputProcessor`. The redundant computation can lead to errors, particularly when the content exceeds 64KB, as specified by the CWL standard.
LanderOtto
force-pushed
the
fix/collector-content
branch
from
4d87434 to
31d27d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves an issue that occurs when a
CommandLineToolis executed directly and its output includesloadContents. Before to this fix, theTokenProcessorin the collector step incorrectly attempted to compute the content loading. However, this loading should only be handled by theCommandOutputProcessorof theExecuteStep. The redundant computation can lead to errors, particularly when the content exceeds 64KB.