feat: add eip-7685 requests root to header #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
requested review from
DaniPopes,
Evalir,
gakonst,
mattsse and
prestwich
as code owners
Contributor
Author
|
@mattsse yeah i'm opening PRs as I progress on paradigmxyz/reth#8053, we need to add some fields to body + calc the root itself, will keep the alloy impl on par |
Member
|
should we be managing changes in e.g. an enum over versions? |
Member
while this would have advantages, we'd still need this type for decoding any rlp blob or we need additional context for decoding, like the hardfork so we know how to decode |
Member
|
great i love it when field semantics change without any structural indication 🎉 |
Rjected
approved these changes
May 2, 2024
Comment on lines
+299
to
+309
| // Encode requests root length. | ||
| // | ||
| // If new fields are added, the above pattern will | ||
| // need to be repeated and placeholder length added. Otherwise, it's impossible to | ||
| // tell _which_ fields are missing. This is mainly relevant for contrived cases | ||
| // where a header is created at random, for example: | ||
| // * A header is created with a withdrawals root, but no base fee. Shanghai blocks are | ||
| // post-London, so this is technically not valid. However, a tool like proptest would | ||
| // generate a block like this. | ||
| if let Some(parent_beacon_block_root) = self.parent_beacon_block_root { | ||
| length += parent_beacon_block_root.length(); | ||
| if let Some(requests_root) = self.requests_root { | ||
| length += requests_root.length(); |
Contributor
There was a problem hiding this comment.
note: the hack in this comment is not needed in reth any more, the arbitrary impl was changed instead, we should copy it over so the encoding / decoding impl is more sensible
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* feat: add eip-7685 requests root to header * feat: requests root for consensus header * chore: fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds EIP-7685 header fields to both the consensus and RPC
Headertypes.PR Checklist