chore: EIP-7685 changes #1599
Merged
chore: EIP-7685 changes #1599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
DaniPopes,
emhane,
gakonst,
mattsse and
onbjerg
as code owners
Member
|
good to merge? |
Member
Author
|
let's hold off a bit, the corresponding PRs are not yet merged and we don't yet have a devnet-5 date |
zerosnacks
added
the
blocked
mattsse
approved these changes
Nov 27, 2024
mattsse
removed
the
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ethereum/execution-apis#599
ethereum/EIPs#8989
Requests are now sent along with the type byte and empty requests are ommited. Thus, requests_hash calculation and empty requests hash need updates
Solution
PR Checklist