Latest esrun configs #218
Open
Latest esrun configs #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favyen2
requested changes
Oct 3, 2025
| project: ${WANDB_PROJECT} | ||
| name: ${WANDB_NAME} | ||
| entity: ${WANDB_ENTITY} | ||
| # FIXME ${TRAINER_DATA_PATH} |
There was a problem hiding this comment.
What is the reason to move it from configuring things properly to having it in a comment?
|
I don't understand the reason for these changes, it seems to be reverting all of the changes I made to get it working with the latest esrun. |
favyen2
reviewed
Oct 3, 2025
| - class_path: rslp.helios.model.Helios | ||
| init_args: | ||
| checkpoint_path: ${EXTRA_FILES_PATH}/yawenzzzz/latent_mim_cross_random_per_modality_patchdisc_add_contrastive_0.1_1/step400000 | ||
| checkpoint_path: gs://earth-system-run-dev/models/02ce432e-98e7-46d7-8a67-a1d9b346e746/stage_0/helios/step300000 |
There was a problem hiding this comment.
I don't think we should workaround things just by putting variables like EXTRA_FILES_PATH in a comment. If there is support to pass EXTRA_FILES_PATH to the local runner then we should do that, the path is gs://ai2-rslearn-projects-data/helios/checkpoints/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.