Skip to content

fix(specs): fix missing params and types #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 4, 2022
Merged

fix(specs): fix missing params and types #772

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
48cd2a1
fix(specs): fix missing params and types
shortcuts Jul 4, 2022
caf82d2
Merge branch 'main' into fix/specs-params
shortcuts Jul 4, 2022
7a2a716
fix matrix run conditions
shortcuts Jul 4, 2022
5a33584
restore deleted file
shortcuts Jul 4, 2022
5f616d5
review
shortcuts Jul 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/.cache_version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.0.9
0.0.10
13 changes: 5 additions & 8 deletions config/generation.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,10 @@ module.exports = {

// PHP
'!clients/algoliasearch-client-php/*',
'!clients/algoliasearch-client-php/lib/*',
'!clients/algoliasearch-client-php/lib/Cache/**',
'!clients/algoliasearch-client-php/lib/Exceptions/**',
'!clients/algoliasearch-client-php/lib/Http/**',
'!clients/algoliasearch-client-php/lib/Log/**',
'!clients/algoliasearch-client-php/lib/RequestOptions/**',
'!clients/algoliasearch-client-php/lib/RetryStrategy/**',
'!clients/algoliasearch-client-php/lib/Support/**',
'clients/algoliasearch-client-php/lib/Api/*',
'clients/algoliasearch-client-php/lib/Model/**',
'clients/algoliasearch-client-php/lib/Configuration/*',
'clients/algoliasearch-client-php/lib/ApiException.php',
'clients/algoliasearch-client-php/lib/ObjectSerializer.php',
],
};
2 changes: 1 addition & 1 deletion generators/src/main/java/com/algolia/codegen/cts/manager/JavaCTSManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public JavaCTSManager(String client) {

@Override
public void addSupportingFiles(List<SupportingFile> supportingFiles) {
supportingFiles.add(new SupportingFile("build.mustache", ".", "build.gradle"));
supportingFiles.add(new SupportingFile("build.mustache", "", "build.gradle"));
}

@Override
Expand Down
8 changes: 7 additions & 1 deletion generators/src/main/java/com/algolia/codegen/cts/tests/ParametersWithDataType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,13 @@ private void handleModel(
}
if (varSpec == null) {
throw new CTSException(
"Parameter " + entry.getKey() + " not found in " + paramName + ". You might have a type conflict in the spec for " + baseType
"Parameter '" +
entry.getKey() +
"' not found in '" +
paramName +
"'. You might have a type conflict in the spec for '" +
baseType +
"'"
);
}

Expand Down
7 changes: 1 addition & 6 deletions scripts/ci/githubActions/createMatrix.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,12 +128,7 @@ async function getSpecMatrix(): Promise<void> {
};

for (const client of CLIENTS) {
// `algoliasearch` is an aggregation of client
if (client === 'algoliasearch') {
continue;
}

// The `lite` spec is created by the `search` spec
// The `algoliasearch` spec is created by the `search` spec, for the `lite` JavaScript client.
const bundledSpecName = client === 'algoliasearch' ? 'search' : client;

matrix.toRun.push(client);
Expand Down
1 change: 0 additions & 1 deletion scripts/ci/husky/__tests__/pre-commit.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ describe('micromatch', () => {

'clients/algoliasearch-client-php/.gitignore',
'clients/algoliasearch-client-php/lib/Api/SearchClient.php',
'clients/algoliasearch-client-php/lib/Cache/FileCacheDriver.php',

'tests/output/java/build.gradle',
'tests/output/java/settings.gradle',
Expand Down
6 changes: 5 additions & 1 deletion specs/abtesting/common/parameters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@ endAt:

createdAt:
type: string
description: End date for the A/B test expressed as YYYY-MM-DDThh:mm:ssZ.
description: Create date for the A/B test expressed as YYYY-MM-DDThh:mm:ssZ.

updatedAt:
type: string
description: Update date for the A/B test expressed as YYYY-MM-DDThh:mm:ssZ.

name:
type: string
Expand Down
3 changes: 3 additions & 0 deletions specs/abtesting/common/schemas/ABTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ ABTest:
description: A/B test significance based on conversion data. Should be > 0.95 to be considered significant (no matter which variant is winning).
endAt:
$ref: '../parameters.yml#/endAt'
updatedAt:
$ref: '../parameters.yml#/updatedAt'
createdAt:
$ref: '../parameters.yml#/createdAt'
name:
Expand All @@ -34,6 +36,7 @@ ABTest:
- name
- createdAt
- endAt
- updatedAt
- conversionSignificance
- clickSignificance
- abTestID
Expand Down
Loading