fix(http_requester): use host url as connections cache key #496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
Use the
host.url, which should be unique, instead of thehost.acceptvalue, which in most cases is not unique, when caching the http client in the@connectionsinstance variable ofhttp_requesterWhat problem is this fixing?
Failing to do that, all hosts will actually use the same http client as the first one (assuming they share the same
acceptvalue). This prevents the retry strategy from working properlyFor example:
host1,host2&host3configured.host1is down.algolia_client.indexestransporter->retry_strategy->http_requesterwill try to request host1 and instantiate an http client with its url.http_requester.connections[host2.accept]will yield the same http client ashost1!