Calculate Packet Loss Statistics #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Python 3.5 support and improve docs
…nary to be more efficient and faster for lookup
Fix network.py Intermittent Threaded Usage Failures due to Python Built-In Bug
|
Just had a quick review and the code looks good, but it lacks testing. @samgomena can you please add unit testings for this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on #58 this PR adds:
ResponseListobject that returns the percent of packets lost where 0% packets lost = a return value of0.0and 100% packet loss = a return value of1.0. The number is calculated as a running average so no additional computation is done when the method is called.I didn't add this stat to the
__repr__method, but would be happy to if you think it would be useful!Thanks for reviewing in advance!