Skip to content
This repository was archived by the owner on Jul 6, 2025. It is now read-only.

Conversation

shadowtime2000
Copy link
Member

Fix the sass tests so that they pass

@shadowtime2000 shadowtime2000 requested a review from ije as a code owner January 21, 2021 20:18

- name: Run tests
run: deno test -A --unstable
run: deno test -A --unstable --location "http://localhost/"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just opted to set a default location when running the tests

@shadowtime2000 shadowtime2000 changed the base branch from master to swc January 21, 2021 21:03
@shadowtime2000
Copy link
Member Author

Changing the target branch to SWC because that branch also has the fix for the only other failure. @ije How do you feel about setting a location in the testing?

Copy link
Member

@ije ije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shadowtime2000 shadowtime2000 merged commit af78991 into swc Jan 22, 2021
@shadowtime2000 shadowtime2000 deleted the fix-sass-tests branch January 22, 2021 02:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants