Solve IPFS size handling

.github/workflows/pytest.yml

@@ -63,7 +63,7 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y libpq-dev libsodium-dev libgmp-dev
       - run: |
-          pip install hatch coverage
+          pip install "click<8.2" hatch coverage
 
       - run: |
           sudo cp .github/openssl-ci.cnf /etc/ssl/openssl.cnf

src/aleph/jobs/job_utils.py

@@ -17,8 +17,8 @@
 from aleph.types.message_processing_result import RejectedMessage, WillRetryMessage
 from aleph.types.message_status import (
     ErrorCode,
-    FileNotFoundException,
     InvalidMessageException,
+    MessageContentUnavailable,
     RetryMessageException,
 )
 
@@ -221,7 +221,8 @@ async def _handle_retry(
         pending_message: PendingMessageDb,
         exception: BaseException,
     ) -> Union[RejectedMessage, WillRetryMessage]:
-        if isinstance(exception, FileNotFoundException):
+        error_code = ErrorCode.INTERNAL_ERROR
+        if isinstance(exception, MessageContentUnavailable):
             LOGGER.warning(
                 "Could not fetch message %s, putting it back in the fetch queue: %s",
                 pending_message.item_hash,
@@ -233,20 +234,11 @@ async def _handle_retry(
                 .where(PendingMessageDb.id == pending_message.id)
                 .values(fetched=False)
             )
-        elif isinstance(exception, RetryMessageException):
-            LOGGER.warning(
-                "%s error (%d) - message %s marked for retry",
-                exception.error_code.name,
-                exception.error_code.value,
-                pending_message.item_hash,
-            )
-            error_code = exception.error_code
-            schedule_next_attempt(session=session, pending_message=pending_message)
-        else:
+        elif not isinstance(exception, RetryMessageException):
             LOGGER.exception(
                 "Unexpected error while fetching message", exc_info=exception
             )
-            error_code = ErrorCode.INTERNAL_ERROR
+
         if pending_message.retries >= self.max_retries:
             LOGGER.warning(
                 "Rejecting pending message: %s - too many retries",
@@ -258,6 +250,11 @@ async def _handle_retry(
                 exception=exception,
             )
         else:
+            LOGGER.warning(
+                "Message %s marked for retry: %s",
+                pending_message.item_hash,
+                str(exception),
+            )
             schedule_next_attempt(session=session, pending_message=pending_message)
             return WillRetryMessage(
                 pending_message=pending_message, error_code=error_code

src/aleph/services/ipfs/service.py

@@ -10,7 +10,7 @@
 
 from aleph.services.ipfs.common import make_ipfs_client
 from aleph.services.utils import get_IP
-from aleph.types.message_status import FileContentUnavailable, FileUnavailable
+from aleph.types.message_status import FileUnavailable
 from aleph.utils import run_in_executor
 
 LOGGER = logging.getLogger(__name__)
@@ -120,9 +120,7 @@ async def get_ipfs_size(
                 await asyncio.sleep(0.5)
                 continue
             except asyncio.TimeoutError:
-                raise FileContentUnavailable(
-                    "Could not retrieve IPFS content at this time"
-                )
+                raise FileUnavailable("Could not retrieve IPFS content at this time")
             except (
                 concurrent.futures.CancelledError,
                 aiohttp.client_exceptions.ClientConnectorError,

src/aleph/types/message_status.py

@@ -169,16 +169,6 @@ def __init__(self, file_hash: str):
         super().__init__(f"File not found: {file_hash}")
 
 
-class FileContentNotFoundException(RetryMessageException):
-    """
-    A file required to process the message could not be found, locally and/or
-    on the network.
-    """
-
-    def __init__(self, file_hash: str):
-        super().__init__(f"File content not found: {file_hash}")
-
-
 class MessageContentUnavailable(FileNotFoundException):
     """
     The message content is not available at the moment (storage/IPFS item types).
@@ -195,14 +185,6 @@ class FileUnavailable(FileNotFoundException):
     error_code = ErrorCode.FILE_UNAVAILABLE
 
 
-class FileContentUnavailable(FileContentNotFoundException):
-    """
-    A file pointed to by the message is not available at the moment.
-    """
-
-    error_code = ErrorCode.FILE_UNAVAILABLE
-
-
 class NoAmendTarget(InvalidMessageException):
     """
     A POST with type = amend does not specify a value in the ref field.

tests/services/test_ipfs_service.py

@@ -6,7 +6,7 @@
 import pytest
 
 from aleph.services.ipfs.service import IpfsService
-from aleph.types.message_status import FileContentUnavailable
+from aleph.types.message_status import FileUnavailable
 
 
 @pytest.mark.asyncio
@@ -205,7 +205,7 @@ async def test_get_ipfs_size_timeout_error():
 
     service = IpfsService(ipfs_client=ipfs_client)
 
-    with pytest.raises(FileContentUnavailable):
+    with pytest.raises(FileUnavailable):
         # Mock asyncio.sleep to not actually sleep during test
         with patch("asyncio.sleep", new_callable=AsyncMock):
             # Execute