Skip to content

Conversation

@amalcaraz
Copy link
Collaborator

Self proofreading checklist

  • Is my code clear enough and well documented
  • Are my files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • Database migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

  • Implements automated balance checking cron job that monitors account balances and manages message storage lifecycle based on funding status
  • Adds grace period mechanism for message removal and recovery, with comprehensive database migrations and test coverage

How to test

  • Verify database migrations apply correctly
  • Test balance job marks messages for removal when balance insufficient
  • Test messages below cutoff height are ignored
  • Test message recovery when balance becomes sufficient
  • Verify grace period file pins are created/updated correctly
  • Test cron job scheduling and execution
  • Run existing test suite to ensure no regressions

@amalcaraz amalcaraz requested a review from nesitor May 23, 2025 14:30
@amalcaraz amalcaraz marked this pull request as ready for review May 23, 2025 15:07
@amalcaraz amalcaraz force-pushed the angel-balance_check_garbage_collector_cron_job branch from 0bfb1d2 to b430895 Compare May 29, 2025 14:09
@amalcaraz amalcaraz self-assigned this May 29, 2025
@amalcaraz amalcaraz added the enhancement New feature or request label May 29, 2025
nesitor
nesitor previously approved these changes Jun 2, 2025
@amalcaraz amalcaraz force-pushed the angel-balance_check_garbage_collector_cron_job branch from 4c38768 to dc8beb0 Compare June 2, 2025 11:15
@amalcaraz amalcaraz requested a review from nesitor June 2, 2025 11:15
@nesitor nesitor merged commit 969a742 into main Jun 2, 2025
5 checks passed
@nesitor nesitor deleted the angel-balance_check_garbage_collector_cron_job branch June 2, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants