ALEPH-408 Storage on a CCN should be an option #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psycojoker
force-pushed
the
store-files_false
branch
3 times, most recently
from
1c79780 to
78e3f15
Compare
hoh
reviewed
Feb 27, 2025
Psycojoker
force-pushed
the
store-files_false
branch
from
78e3f15 to
5aa494d
Compare
Psycojoker
force-pushed
the
store-files_false
branch
from
2a6872d to
eec876a
Compare
hoh
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Clickup or Jira tickets : ALEPH-408
Self proofreading checklist
Changes
I'm not 100% sure about this approach but I've changed the behavior from doing
nothing to pretending we are storing a file in the database with a size of -1
while not doing the standard lookup nor talking to IPFS.
I'm wondering if we still shouldn't talk to IPFS but prevent it from pinning
the file? It's unclear to me if we actually want to pin the file here.
How to test
The tests should take care of it but I haven't been able to find how to
simulate a new message asking to store a file yet.