Skip to content

Feature: support Micheline-style signatures for Tezos #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2022
Merged

Feature: support Micheline-style signatures for Tezos #330

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f364fd
Feature: support Micheline-style signatures for Tezos
odesenfans Sep 24, 2022
25cce5e
Update src/aleph/chains/tezos.py
MHHukiewitz Sep 26, 2022
86c5a02
fixes for review
odesenfans Sep 26, 2022
62ca2b6
revert reading field: now "dAppUrl"
MHHukiewitz Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/aleph/chains/tezos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
LOGGER = logging.getLogger(__name__)
CHAIN_NAME = "TEZOS"

# Default dApp URI for Micheline-style signatures
DEFAULT_DAPP_URI = "aleph.im"
# Default dApp URL for Micheline-style signatures
DEFAULT_DAPP_URL = "aleph.im"


class TezosSignatureType(str, Enum):
Expand Down Expand Up @@ -43,7 +43,7 @@ def timestamp_to_iso_8601(timestamp: float) -> str:
def micheline_verification_buffer(
verification_buffer: bytes,
timestamp: float,
dapp_uri: str,
dapp_url: str,
) -> bytes:
"""
Computes the verification buffer for Micheline-type signatures.
Expand All @@ -53,14 +53,15 @@ def micheline_verification_buffer(

:param verification_buffer: The original (non-Tezos) verification buffer for the Aleph message.
:param timestamp: Timestamp of the message.
:param dapp_url: The URL of the dApp, for use as part of the verification buffer.
:return: The verification buffer used for the signature by the web wallet.
"""

prefix = b"Tezos Signed Message:"
timestamp = timestamp_to_iso_8601(timestamp).encode("utf-8")

payload = b" ".join(
(prefix, dapp_uri.encode("utf-8"), timestamp, verification_buffer)
(prefix, dapp_url.encode("utf-8"), timestamp, verification_buffer)
)
hex_encoded_payload = payload.hex()
payload_size = str(len(hex_encoded_payload)).encode("utf-8")
Expand All @@ -69,15 +70,15 @@ def micheline_verification_buffer(


def get_tezos_verification_buffer(
message: BasePendingMessage, signature_type: TezosSignatureType, dapp_uri: str
message: BasePendingMessage, signature_type: TezosSignatureType, dapp_url: str
) -> bytes:
verification_buffer = get_verification_buffer(message)

if signature_type == TezosSignatureType.RAW:
return verification_buffer
elif signature_type == TezosSignatureType.MICHELINE:
return micheline_verification_buffer(
verification_buffer, message.time, dapp_uri
verification_buffer, message.time, dapp_url
)

raise ValueError(f"Unsupported signature type: {signature_type}")
Expand All @@ -102,7 +103,7 @@ async def verify_signature(message: BasePendingMessage) -> bool:
return False

signature_type = TezosSignatureType(signature_dict.get("signingType", "raw"))
dapp_uri = signature_dict.get("dAppUrl", DEFAULT_DAPP_URI)
dapp_url = signature_dict.get("dappUrl", DEFAULT_DAPP_URL)

key = Key.from_encoded_key(public_key)
# Check that the sender ID is equal to the public key hash
Expand All @@ -116,7 +117,7 @@ async def verify_signature(message: BasePendingMessage) -> bool:
)

verification_buffer = get_tezos_verification_buffer(
message, signature_type, dapp_uri
message, signature_type, dapp_url
)

# Check the signature
Expand Down