Skip to content

fixed api call bug #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed api call bug #3537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ...ard/web/polaris_web/web/src/apps/dashboard/pages/threat_detection/ThreatDashboardPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ function ThreatDashboardPage() {
const totalActive = summaryResponse.totalActiveStatus || 0
const totalIgnored = summaryResponse.totalIgnoredStatus || 0
const totalUnderReview = summaryResponse.totalUnderReviewStatus || 0
const total = totalActive + totalIgnored + totalUnderReview

const statusData = {
"Active": {
Expand All @@ -124,11 +123,6 @@ function ThreatDashboardPage() {
"color": observeFunc.getColorForStatus("Ignored"),
"filterKey": "Ignored"
},
"Total": {
"text": total,
"color": observeFunc.getColorForStatus("Total"),
"filterKey": "Total"
}
}
setThreatStatusBreakdown(statusData)
}
Expand Down
42 changes: 20 additions & 22 deletions ...t-detection-backend/src/main/java/com/akto/threat/backend/service/ThreatActorService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ public DailyActorsCountResponse getDailyActorCounts(String accountId, long start
new Document("$sum",
new Document("$cond",
Arrays.asList(
new Document("$eq", Arrays.asList("$severity", "HIGH")),
new Document("$eq", Arrays.asList("$severity", "CRITICAL")),
1,
0))))));

Expand Down Expand Up @@ -351,6 +351,7 @@ public DailyActorsCountResponse getDailyActorCounts(String accountId, long start
if (!matchConditions.isEmpty()) {
statusPipeline.add(new Document("$match", matchConditions));
}
// Group by status and actor to get distinct actors per status
statusPipeline.add(new Document("$group",
new Document("_id", "$status").append("count", new Document("$sum", 1))));

Expand Down Expand Up @@ -665,33 +666,30 @@ public FetchTopNDataResponse fetchTopNData(
pipeline.add(new Document("$match", match));
}

// Group by endpoint and method, count attacks, get max severity
// Group by endpoint, method, and severity to get separate rows per severity level
// First, add a stage to normalize severity (handle null, case-insensitive)
pipeline.add(new Document("$addFields",
new Document("normalizedSeverity",
new Document("$ifNull", Arrays.asList(
new Document("$toUpper", "$severity"),
"UNKNOWN"
))
)
));

// Group by endpoint, method, and severity to get count per severity
pipeline.add(new Document("$group",
new Document("_id", new Document("endpoint", "$latestApiEndpoint").append("method", "$latestApiMethod"))
.append("attacks", new Document("$sum", 1))
.append("maxSeverityPriority",
new Document("$max",
new Document("$switch",
new Document("branches", Arrays.asList(
new Document("case", new Document("$eq", Arrays.asList("$severity", "CRITICAL"))).append("then", 4),
new Document("case", new Document("$eq", Arrays.asList("$severity", "HIGH"))).append("then", 3),
new Document("case", new Document("$eq", Arrays.asList("$severity", "MEDIUM"))).append("then", 2),
new Document("case", new Document("$eq", Arrays.asList("$severity", "LOW"))).append("then", 1)))
.append("default", 0))))));
new Document("_id", new Document("endpoint", "$latestApiEndpoint")
.append("method", "$latestApiMethod")
.append("severity", "$normalizedSeverity"))
.append("attacks", new Document("$sum", 1))));

// Project to convert severity priority back to string
// Project to flatten the structure
pipeline.add(new Document("$project",
new Document("endpoint", "$_id.endpoint")
.append("method", "$_id.method")
.append("attacks", 1)
.append("severity",
new Document("$switch",
new Document("branches", Arrays.asList(
new Document("case", new Document("$eq", Arrays.asList("$maxSeverityPriority", 4))).append("then", "CRITICAL"),
new Document("case", new Document("$eq", Arrays.asList("$maxSeverityPriority", 3))).append("then", "HIGH"),
new Document("case", new Document("$eq", Arrays.asList("$maxSeverityPriority", 2))).append("then", "MEDIUM"),
new Document("case", new Document("$eq", Arrays.asList("$maxSeverityPriority", 1))).append("then", "LOW")))
.append("default", "UNKNOWN")))));
.append("severity", "$_id.severity")));

// Sort by attacks descending
pipeline.add(new Document("$sort", new Document("attacks", -1)));
Expand Down