-
Notifications
You must be signed in to change notification settings - Fork 266
threat highlighting #3515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
threat highlighting #3515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 AI Security analysis: "Automated scan reported no findings for the changed files, but this does not guarantee absence of vulnerabilities. Residual risks include undetected logic flaws, gaps in test or scan coverage, and changes to dependencies or configurations."
| Risk Level | AI Score |
|---|---|
| 🟢 NO RISK | 5.0/100 |
Top 0 security issues / 0 total (Critical: 0, High: 0, Medium: 0, Low: 0)
| Title | Location | Recommendation |
|---|---|---|
| — | — | No issues to display |
| /* strong red inline highlight for detected vulnerabilities */ | ||
| background-color: rgba(215, 43, 12, 0.18) !important; /* light red background */ | ||
| color: #A91F0A !important; /* dark red text for contrast */ | ||
| font-weight: 700 !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont use red color as we already in editor show diff with red and green between actual and attempted request
| end = idx + phrase.length; | ||
| valid = true; | ||
| } else { | ||
| valid = (start !== undefined && end !== undefined && start >= 0 && end <= text.length && start < end); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets try to simplify this logic
too many if conditions
try to make code more readable
| if (valid) { | ||
| const startPos = model.getPositionAt(start); | ||
| const endPos = model.getPositionAt(end); | ||
| console.log(`🔴 Segment ${index}: start=${start}, end=${end}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove log
| color: #6B46C1 !important; | ||
| font-weight: 600 !important; | ||
| /* strong red inline highlight for detected vulnerabilities */ | ||
| background-color: rgba(215, 43, 12, 0.18) !important; /* light red background */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont use red color
as well alreay use red and green for diff check in editor
| for (FilterConfig apiFilter : apiFilters.values()) { | ||
| boolean hasPassedFilter = false; | ||
| // Create a fresh errors list for each filter | ||
| List<SchemaConformanceError> errors = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename it to vulnerable
| let segmentsFromMetadata = false; | ||
| // Prefer explicit prop; fallback to per-row metadata | ||
| const effectiveMetadata = (metadata !== undefined && metadata !== null) ? metadata : sampleData?.metadata; | ||
| console.log(effectiveMetadata, typeof effectiveMetadata); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see how we can improve this as well
simplify the logic
| .setPhrase(emit.getKeyword()) | ||
| .build(); | ||
| errors.add(error); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repeating code
and for threat code get it verify from Ayush as well
|
|
||
| message SchemaConformanceError { | ||
| enum Location { | ||
| LOCATION_UNSPECIFIED = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unspecified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 AI Security analysis: "No security issues were detected in this change set; residual risks remain."
| Risk Level | AI Score |
|---|---|
| 🟢 NO RISK | 5.0/100 |
Top 0 security issues / 0 total (Critical: 0, High: 0, Medium: 0, Low: 0)
| Title | Location | Recommendation |
|---|---|---|
| — | — | No issues to display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 AI Security analysis: "No security issues were detected in this change set; residual risks remain."
| Risk Level | AI Score |
|---|---|
| 🟢 NO RISK | 5.0/100 |
Top 0 security issues / 0 total (Critical: 0, High: 0, Medium: 0, Low: 0)
| Title | Location | Recommendation |
|---|---|---|
| — | — | No issues to display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 AI Security analysis: "No security issues were detected in this change set; residual risks remain."
| Risk Level | AI Score |
|---|---|
| 🟢 NO RISK | 5.0/100 |
Top 0 security issues / 0 total (Critical: 0, High: 0, Medium: 0, Low: 0)
| Title | Location | Recommendation |
|---|---|---|
| — | — | No issues to display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 AI Security analysis: "No security issues were detected in this change set; residual risks remain."
| Risk Level | AI Score |
|---|---|
| 🟢 NO RISK | 5.0/100 |
Top 0 security issues / 0 total (Critical: 0, High: 0, Medium: 0, Low: 0)
| Title | Location | Recommendation |
|---|---|---|
| — | — | No issues to display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 AI Security analysis: "No security issues were detected in this change set; residual risks remain."
| Risk Level | AI Score |
|---|---|
| 🟢 NO RISK | 5.0/100 |
Top 0 security issues / 0 total (Critical: 0, High: 0, Medium: 0, Low: 0)
| Title | Location | Recommendation |
|---|---|---|
| — | — | No issues to display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 AI Security analysis: "No security issues were detected in this change set; residual risks remain."
| Risk Level | AI Score |
|---|---|
| 🟢 NO RISK | 5.0/100 |
Top 0 security issues / 0 total (Critical: 0, High: 0, Medium: 0, Low: 0)
| Title | Location | Recommendation |
|---|---|---|
| — | — | No issues to display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 AI Security analysis: "Automated security scan found no issues in the changed files; no vulnerabilities or fixes required. Low security risk; proceed with normal review."
| Risk Level | AI Score |
|---|---|
| 🟢 NO RISK | 10.0/100 |
Top 0 security issues / 0 total (Critical: 0, High: 0, Medium: 0, Low: 0)
| Title | Location | Recommendation |
|---|---|---|
| — | — | No issues to display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 AI Security analysis: "Automated scans reported no security findings for this change. That does not guarantee safety: undetected vulnerabilities, credential leakage in unscanned areas, or missing manual review could still pose risk."
| Risk Level | AI Score |
|---|---|
| 🟢 NO RISK | 0.0/100 |
Top 0 security issues / 0 total (Critical: 0, High: 0, Medium: 0, Low: 0)
| Title | Location | Recommendation |
|---|---|---|
| — | — | No issues to display |
No description provided.