added accountId to each log #3389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravakto
reviewed
Oct 21, 2025
|
|
||
| public void error(String errorMessage, Object... vars) { | ||
| logger.error(errorMessage, vars); | ||
| String accountId = Context.accountId.get() != null ? Context.accountId.get().toString() : "NA"; |
Contributor
There was a problem hiding this comment.
create a common function
getFormattedMessage use it everyhwere
gauravakto
reviewed
Oct 21, 2025
Comment on lines
160
to
162
| if (Context.accountId.get() != null) { | ||
| err = String.format("%s\naccountId: %d", err, Context.accountId.get()); | ||
| } |
Contributor
There was a problem hiding this comment.
we don't need this? formattedMessage will anyways add the accountID
gauravakto
reviewed
Oct 21, 2025
| */ | ||
| private String getFormattedMessage(String message) { | ||
| String accountId = Context.accountId.get() != null ? Context.accountId.get().toString() : "NA"; | ||
| return "accountId: " + accountId + ", " + message; |
Contributor
There was a problem hiding this comment.
For each log line we need to make it parseable by code/regex. For that we must have specfic format. Let's keep this for now.
`return "accountId: " + accountId + " message: " + message;
gauravakto
merged commit b113330
into
akto-api-security:feature/fluentd-logging
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.