-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix Hyperion serializer config bug #7364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Aaronontheweb
merged 2 commits into
akkadotnet:dev
from
Arkatufus:fix-hyperion-serializer
Oct 25, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
152 changes: 76 additions & 76 deletions
152
src/contrib/serializers/Akka.Serialization.Hyperion/reference.conf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,80 +1,80 @@ | ||
| akka.actor { | ||
| serializers { | ||
| hyperion = "Akka.Serialization.HyperionSerializer, Akka.Serialization.Hyperion" | ||
| } | ||
| serialization-settings { | ||
| hyperion { | ||
| # If true, hyperion serializer will preserve references between objects. | ||
| # This is necessary to support things such as cyclic dependencies between objects. | ||
| preserve-object-references = true | ||
| serializers { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nothing is changed on the default config file, all changes were white space changes from tab to spaces to make sure that text formatting is consistent |
||
| hyperion = "Akka.Serialization.HyperionSerializer, Akka.Serialization.Hyperion" | ||
| } | ||
| serialization-settings { | ||
| hyperion { | ||
| # If true, hyperion serializer will preserve references between objects. | ||
| # This is necessary to support things such as cyclic dependencies between objects. | ||
| preserve-object-references = true | ||
|
|
||
| # If true, hyperion serializer will append an information about serialized fields | ||
| # to a type manifest. This will increase the payload size of the serialized message, | ||
| # but will also allow to provide a limited tolerance to message schema changes | ||
| # between actor systems using different assembly versions, making incremental | ||
| # cluster updates less restrictive. | ||
| version-tolerance = true | ||
|
|
||
| # If disallow-unsafe-type is set to true, hyperion serializer will block potentially | ||
| # dangerous and unsafe types from being deserialized during run-time. | ||
| # | ||
| # Please check this link if you need to read more about this setting: | ||
| # https://getakka.net/articles/networking/serialization.html#danger-of-polymorphic-serializer | ||
| disallow-unsafe-type = true | ||
|
|
||
| # A fully qualified type name with assembly to a type implementing | ||
| # `Akka.Serialization.IKnownTypesProvider` interface, that can be used to supply | ||
| # hyperion serializer with a list of types, that are expected to be well-known for | ||
| # all communicating parties, effectively reducing a manifests size and serialization | ||
| # time. No types are known by default. Implementing class must expose either a default | ||
| # constructor or constructor accepting an `ExtendedActorSystem` as its only parameter. | ||
| known-types-provider = "Akka.Serialization.NoKnownTypes, Akka.Serialization.Hyperion" | ||
|
|
||
| # If true, hyperion serializer will append an information about serialized fields | ||
| # to a type manifest. This will increase the payload size of the serialized message, | ||
| # but will also allow to provide a limited tolerance to message schema changes | ||
| # between actor systems using different assembly versions, making incremental | ||
| # cluster updates less restrictive. | ||
| version-tolerance = true | ||
|
|
||
| # If disallow-unsafe-type is set to true, hyperion serializer will block potentially | ||
| # dangerous and unsafe types from being deserialized during run-time. | ||
| # | ||
| # Please check this link if you need to read more about this setting: | ||
| # https://getakka.net/articles/networking/serialization.html#danger-of-polymorphic-serializer | ||
| disallow-unsafe-type = true | ||
| # An array of fully qualified class names of types that are allowed to be deserialized | ||
| # during run-time. When left as an empty array, type filtering will be disabled. | ||
| allowed-types = [] | ||
|
|
||
| # A fully qualified type name with assembly to a type implementing | ||
| # `Akka.Serialization.IKnownTypesProvider` interface, that can be used to supply | ||
| # hyperion serializer with a list of types, that are expected to be well-known for | ||
| # all communicating parties, effectively reducing a manifests size and serialization | ||
| # time. No types are known by default. Implementing class must expose either a default | ||
| # constructor or constructor accepting an `ExtendedActorSystem` as its only parameter. | ||
| known-types-provider = "Akka.Serialization.NoKnownTypes, Akka.Serialization.Hyperion" | ||
|
|
||
| # An array of fully qualified class names of types that are allowed to be deserialized | ||
| # during run-time. When left as an empty array, type filtering will be disabled. | ||
| allowed-types = [] | ||
|
|
||
| # A list of incompatible dll package name for deserializing types | ||
| # between NetFx, .NET Core, and the new .NET | ||
| # Used to map and rename/correct different dll names between different platforms | ||
| # in the .NET ecosystem. | ||
| # | ||
| # How it works is that when the serializer detects that the type name contains | ||
| # the fingerprint string, it will replace the string declared in the rename-from | ||
| # property into the string declared in the rename-to property. | ||
| # | ||
| # if(packageName.Contains(fingerprint)) packageName = packageName.Replace(rename-from, rename-to); | ||
| # | ||
| # The commented values below are the default values used in the serializer, | ||
| # provided as an example on how to use this feature. | ||
| cross-platform-package-name-overrides = { | ||
| # netfx = [ | ||
| # { | ||
| # fingerprint = "System.Private.CoreLib,%core%", | ||
| # rename-from = "System.Private.CoreLib,%core%", | ||
| # rename-to = "mscorlib,%core%" | ||
| # }] | ||
| # netcore = [ | ||
| # { | ||
| # fingerprint = "mscorlib,%core%", | ||
| # rename-from = "mscorlib,%core%", | ||
| # rename-to = "System.Private.CoreLib,%core%" | ||
| # }] | ||
| # net = [ | ||
| # { | ||
| # fingerprint = "mscorlib,%core%", | ||
| # rename-from = "mscorlib,%core%", | ||
| # rename-to = "System.Private.CoreLib,%core%" | ||
| # }] | ||
| } | ||
|
|
||
| # An array of fully qualified class names of classes inheriting Hyperion.Surrogate class. | ||
| # These classes will be used to transform one complex class into another much simpler class | ||
| # that are more suitable for over the wire transport. | ||
| # | ||
| # Please refer to https://getakka.net/articles/networking/serialization.html#complex-object-serialization-using-hyperion | ||
| # for more information. | ||
| surrogates = [] | ||
| } | ||
| } | ||
| # A list of incompatible dll package name for deserializing types | ||
| # between NetFx, .NET Core, and the new .NET | ||
| # Used to map and rename/correct different dll names between different platforms | ||
| # in the .NET ecosystem. | ||
| # | ||
| # How it works is that when the serializer detects that the type name contains | ||
| # the fingerprint string, it will replace the string declared in the rename-from | ||
| # property into the string declared in the rename-to property. | ||
| # | ||
| # if(packageName.Contains(fingerprint)) packageName = packageName.Replace(rename-from, rename-to); | ||
| # | ||
| # The commented values below are the default values used in the serializer, | ||
| # provided as an example on how to use this feature. | ||
| cross-platform-package-name-overrides = { | ||
| # netfx = [ | ||
| # { | ||
| # fingerprint = "System.Private.CoreLib,%core%", | ||
| # rename-from = "System.Private.CoreLib,%core%", | ||
| # rename-to = "mscorlib,%core%" | ||
| # }] | ||
| # netcore = [ | ||
| # { | ||
| # fingerprint = "mscorlib,%core%", | ||
| # rename-from = "mscorlib,%core%", | ||
| # rename-to = "System.Private.CoreLib,%core%" | ||
| # }] | ||
| # net = [ | ||
| # { | ||
| # fingerprint = "mscorlib,%core%", | ||
| # rename-from = "mscorlib,%core%", | ||
| # rename-to = "System.Private.CoreLib,%core%" | ||
| # }] | ||
| } | ||
|
|
||
| # An array of fully qualified class names of classes inheriting Hyperion.Surrogate class. | ||
| # These classes will be used to transform one complex class into another much simpler class | ||
| # that are more suitable for over the wire transport. | ||
| # | ||
| # Please refer to https://getakka.net/articles/networking/serialization.html#complex-object-serialization-using-hyperion | ||
| # for more information. | ||
| surrogates = [] | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the actual config
HyperionSerializerSettingswas expecting, not the root config.