Skip to content

Akka.Cluster.Tools: fix mutability and oldest state bugs with ClusterSingletonManager #7298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 25, 2024
Merged

Akka.Cluster.Tools: fix mutability and oldest state bugs with ClusterSingletonManager #7298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e392a9b
fix mutability bugs with `ClusterSingletonManager`
Aaronontheweb Jul 24, 2024
679f828
fixed another mutability error
Aaronontheweb Jul 24, 2024
4fbf6a9
explicitly re-order "oldest nodes" based on data received from Oldest…
Aaronontheweb Jul 24, 2024
74e7e68
WIP nullability
Aaronontheweb Jul 24, 2024
8df0c3e
fixed nullability issues and API approvals
Aaronontheweb Jul 25, 2024
6808836
Merge branch 'dev' into fix-6973-early-ClusterSingletonManager-handoff
Aaronontheweb Jul 25, 2024
b2a3b4e
removed debug logging
Aaronontheweb Jul 25, 2024
122b16c
removed old code
Aaronontheweb Jul 25, 2024
9e4a4a9
fixed some nullability issues
Aaronontheweb Jul 25, 2024
7a5d68c
fix racy cluster singleton restart spec
Aaronontheweb Jul 25, 2024
85a93a4
Merge branch 'dev' into fix-6973-early-ClusterSingletonManager-handoff
Aaronontheweb Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/contrib/cluster/Akka.Cluster.Tools.Tests/Singleton/ClusterSingletonRestart2Spec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public ClusterSingletonRestart2Spec(ITestOutputHelper output) : base("""
akka.loglevel = INFO
akka.actor.provider = "cluster"
akka.cluster.roles = [singleton]
#akka.cluster.auto-down-unreachable-after = 2s
akka.cluster.split-brain-resolver.stable-after = 2s
Copy link
Member Author

@Aaronontheweb Aaronontheweb Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fixes for this spec - after doing a thorough review of some the cases where we had a race condition, it all comes down to whether or not _sys1 was able to fully get MemberRemoved or whether or not it became Unreachable first. Speeding up the downing provider's decision-making process both ensures that this member gets removed quickly AND ensures that the number of retries during the HandOver process get capped so the test can complete on-time.

akka.cluster.singleton.min-number-of-hand-over-retries = 5
akka.remote {
dot-netty.tcp {
Expand Down Expand Up @@ -120,7 +120,7 @@ await WithinAsync(TimeSpan.FromSeconds(5), () =>
await Join(_sys4, _sys3);

// let it stabilize
//Task.Delay(TimeSpan.FromSeconds(5)).Wait();
await Task.Delay(TimeSpan.FromSeconds(5));

await WithinAsync(TimeSpan.FromSeconds(10), () =>
{
Expand Down
Loading