Add Redis connectivity health checks #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement IAkkaHealthCheck-based connectivity checks for Redis journal and snapshot stores. These are liveness checks that proactively verify backend database connectivity using PING commands. Changes: - RedisJournalConnectivityCheck: Verifies journal connectivity - RedisSnapshotStoreConnectivityCheck: Verifies snapshot store connectivity - RedisConnectivityCheckSpec: Unit tests with 6 test cases covering healthy/unhealthy scenarios and parameter validation - All 6 tests passing Implements Akka.Hosting Epic #678.
- Upgraded Akka.Hosting from 1.5.53 to 1.5.55-beta1 - Upgraded Akka.NET from 1.5.53 to 1.5.55 - Added RedisConnectivityCheckExtensions with WithConnectivityCheck methods - Uses the new WithCustomHealthCheck() API from Akka.Hosting 1.5.55-beta1 - All 6 connectivity health check tests pass successfully
- Modified RedisConnectivityCheckSpec to use RedisFixture with Docker containers
- Added happy path tests that verify health checks return Healthy when Redis is available:
- Journal_Connectivity_Check_Should_Return_Healthy_When_Connected
- Snapshot_Connectivity_Check_Should_Return_Healthy_When_Connected
- Kept existing unhealthy path tests to verify failure detection
- Added [Collection("RedisSpec")] attribute to share Redis Docker containers across tests
- Tests now properly validate both success and failure scenarios
All 8 tests pass locally, ensuring the liveness checks work correctly on the happy path.
Aaronontheweb
commented
Oct 26, 2025
Member
Author
Aaronontheweb
left a comment
Aaronontheweb
left a comment
There was a problem hiding this comment.
Need to make some changes
| { | ||
| try | ||
| { | ||
| var connection = await ConnectionMultiplexer.ConnectAsync(_connectionString); |
Member
Author
There was a problem hiding this comment.
Do we need to dispose this?
| { | ||
| try | ||
| { | ||
| var connection = await ConnectionMultiplexer.ConnectAsync(_connectionString); |
Member
Author
There was a problem hiding this comment.
Same - do we need to dispose this?
Member
Author
There was a problem hiding this comment.
Tags need to be customizable for all health checks
- Fixed ConnectionMultiplexer disposal using 'using' statements in both Journal and Snapshot connectivity checks - Added customizable tags parameter to WithConnectivityCheck extension methods - Tags default to standard values but can now be customized by users Addresses all three review comments: 1. Proper disposal of Redis connections 2. Customizable tags for health checks
Aaronontheweb
commented
Oct 26, 2025
Member
Author
There was a problem hiding this comment.
Why was the README file packaging removed from this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements connectivity health checks for Redis persistence plugin to enable proactive monitoring of database connectivity status.
RedisJournalConnectivityCheckandRedisSnapshotStoreConnectivityCheckclasses implementingIAkkaHealthCheckTest Plan
References
Implements Akka.Hosting Epic: akkadotnet/Akka.Hosting#678