-
Notifications
You must be signed in to change notification settings - Fork 22
Add persistence support and related tests #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add `PersistenceTestKit` with methods for testing journal and snapshot behaviors, enabling effective simulation of persistence scenarios. - Updated `Akka.Hosting.TestKit.csproj` to include `Akka.Persistence.TestKit` and a reference to `Akka.Persistence.Hosting`. - Add `TestJournalSpec` and `TestSnapshotStoreSpec` with tests for new persistence functionality, covering various scenarios like successful writes and recovery.
|
This example goes against code reusability. I've copied over the PersistanceTestKit implementation and its tests to the Akka.Hosting.TestKit package. |
Arkatufus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Arkatufus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #609
Changes
Please provide a brief description of the changes here.
PersistenceTestKitwith methods for testing journal and snapshot behaviors, enabling effective simulation of persistence scenarios.Akka.Hosting.TestKit.csprojto includeAkka.Persistence.TestKitand a reference toAkka.Persistence.Hosting.TestJournalSpecandTestSnapshotStoreSpecwith tests for new persistence functionality, covering various scenarios like successful writes and recovery.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
devBenchmarksInclude data from the relevant benchmark prior to this change here.
This PR's Benchmarks
Include data from after this change here.