Add module to package.json #2512
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eventualbuddha @Delapouite hello here! ) |
|
Thanks for your contribution @denisx. This change seems to be correct to me, just give me some time to double check. |
|
@jasoniangreen Thanks again for maintaining Ajv! With ESM support, this PR removes the need for interop shims and enables much cleaner imports, especially as projects move toward Node’s ESM defaults. Excited to see it land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
To emulate esm build, you need couple thing at package.json: module and sideeffects
What changes did you make?
Bundlers will cut unused code better then now. Goog for named imports.