Skip to content

Fix reloading after sections updates #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix reloading after sections updates #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 13 additions & 19 deletions MagazineLayout/Public/MagazineLayout.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,19 @@ public final class MagazineLayout: UICollectionViewLayout {
prepareActions.contains(.recreateSectionModels)
{
hasPinnedHeaderOrFooter = false
lastSizedElementMinY = nil
lastSizedElementPreferredHeight = nil
}

// Recreate section models from scratch if necessary
if prepareActions.contains(.recreateSectionModels) {
var sections = [SectionModel]()
for sectionIndex in 0..<currentCollectionView.numberOfSections {
let sectionModel = sectionModelForSection(atIndex: sectionIndex)
sections.append(sectionModel)
}

modelState.setSections(sections)
}

// Update layout metrics if necessary
Expand Down Expand Up @@ -136,25 +149,6 @@ public final class MagazineLayout: UICollectionViewLayout {
}
}

// Recreate section models from scratch if necessary
if prepareActions.contains(.recreateSectionModels) {
var sections = [SectionModel]()
for sectionIndex in 0..<currentCollectionView.numberOfSections {
let sectionModel = sectionModelForSection(atIndex: sectionIndex)
sections.append(sectionModel)
}

modelState.setSections(sections)
}

if
prepareActions.contains(.recreateSectionModels) ||
prepareActions.contains(.updateLayoutMetrics)
{
lastSizedElementMinY = nil
lastSizedElementPreferredHeight = nil
}

prepareActions = []
}

Expand Down