Skip to content

Conversation

@unmarshall
Copy link
Collaborator

@unmarshall unmarshall commented Nov 14, 2025

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

  • Upgrades k8s.io/* dependency versions to v0.34.2
  • Upgrades sigs.k8s.io/controller-runtime to v0.22.4
  • Upgrades github.com/stretchr/testify to v1.11.1
  • Upgrades golang.org/x/net to v0.47.0 (indirect dependency upgrade to resolve a CVE)
  • Upgrades github.com/samber/lo to v1.52.0
  • Upgrades github.com/spf13/pflag to v1.0.10
  • Upgrades helm.sh/helm/v3 to v3.19.2
  • Introduces a convenient make tidy target
  • Client: Native support for Server-Side Apply (SSA), Fake client was adapted to also implement SSA.
  • Re-ran make generate and make generate-api-docs targets which resulted in some doc changes.

In addition to the above this PR also fixes:
An indirect dependency version issue with an explicit replace directive.
github.com/k3d-io/k3d/v5 pulls in github.com/rancher/wharfie which pulls in kubelet but with an incorrect version v0.0.0. A replace directive was added to fix that issue.

You can see the issue reported when you run go list -json -m -u -mod=readonly all command on operator go module.
You will see the following error:

go: k8s.io/[email protected]: invalid version: unknown revision v0.0.0

Which issue(s) this PR fixes:

Fixes #264

Special notes for your reviewer:

Does this PR introduce a API change?

The following dependencies are updated:
- `k8s.io/*`: `v0.33.1` -> `v0.34.2`
- `sigs.k8s.io/controller-runtime`: `v0.21.0` -> `v0.22.4`
- `github.com/stretchr/testify`: `v1.10.0` -> `v1.11.1`
- `helm.sh/helm/v3`:  `v3.19.0` -> `v3.19.2`
- `github.com/samber/lo`: `v1.51.0` -> `v1.52.0`
- `github.com/spf13/pflag`:  `v1.0.9` -> `v1.0.10`
- `golang.org/x/net`: -> v0.47.0
- Introduces a convenience `make tidy` target
- Fixes indirect `kubelet` dependency version

Additional documentation e.g., enhancement proposals, usage docs, etc.:

None

Signed-off-by: Saketh Kalaga <[email protected]>
renormalize
renormalize previously approved these changes Nov 14, 2025
Copy link
Collaborator

@renormalize renormalize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

* Upgraded golang.org/x/net to v0.47.0
* Upgraded github.com/samber/lo to v1.52.0
* Upgraded github.com/spf13/pflag to v1.0.10
* Upgraded helm.sh/helm/v3 to v3.19.2

Signed-off-by: Madhav Bhargava <[email protected]>
@sanjaychatterjee sanjaychatterjee merged commit 2b92e21 into ai-dynamo:main Nov 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade k8s.io/* and sigs.k8s.io/controller-runtime versions and fix transitive dep version for kubelet

3 participants