gh-633: fix fixture methods run with different self than the test method #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
Oct 11, 2024
| has_backend_arg = "anyio_backend" in fixturedef.argnames | ||
| original_func = fixturedef.func | ||
| fixturedef.func = wrapper | ||
| stack.callback(setattr, fixturedef, "func", original_func) |
There was a problem hiding this comment.
this is needed so each request gets a rebound func to request.instance
this should also fix a case where anyio adopts a fixture and then subsequent tests use it
There was a problem hiding this comment.
basically the fixturedef persists across the whole test session, and you need to bind for each test run - so I monkeypatch fixturedef and then roll back the patches
this has a side effect of allowing other test plugins to adopt the fixture if they use the same strategy
I think my explanation is a little poor though
you may notice this approach is totally different from pytest-asyncio's approach. This is because I did not understand it
|
Closing in favor of #807. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #633 .
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) added which would fail without your patchdocs/, in case of behavior changes or newfeatures)
docs/versionhistory.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #123, the entry should look like this:
* Fix big bad boo-boo in task groups (#123 <https://github.com/agronholm/anyio/issues/123>_; PR by @yourgithubaccount)If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.