-
Notifications
You must be signed in to change notification settings - Fork 9
feat: remove ger, unset claims tests #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
approved these changes
Nov 4, 2025
temaniarpit27
added a commit
to agglayer/aggkit
that referenced
this pull request
Nov 4, 2025
## 🔄 Changes Summary - Enable remove ger and unset claim functionality in rare case scenarios - In FEP: we need to send inserted gers and removed gers, claims and unclaims in separate fields (inserted and claims will be unfiltered and will go as it is). using these values provided by us to them, they will generate the proof and return it to us In FEP and PP: we need to filter unclaims from claims which are present in the same cert, if they are in different cert, we dont need to send anything. removed gers dont need to be filtered from inserted gers More desc can be found - agglayer/protocol-research#180 ## ✅ Testing - 🤖 **Automatic**: ./tests/aggkit/bridge-sovereign-chain-e2e.bats ## Config Changes: - Removed `polygonBridgeAddr`. Instead of this use [L1Config.BridgeAddr] and [L2Config.BridgeAddr] to set the respective networks bridge addresses ## 🐞 Issues - Closes #708 ## Dependent PRs - 0xPolygon/kurtosis-cdk#818 - agglayer/e2e#193 --------- Co-authored-by: Goran Rojovic <[email protected]> Co-authored-by: Stefan Negovanović <[email protected]> Co-authored-by: Stefan Negovanović <[email protected]> Co-authored-by: Goran Rojovic <[email protected]> Co-authored-by: Joan Esteban <[email protected]> Co-authored-by: Rachit Sonthalia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
agglayer/aggkit#708
agglayer/aggkit#1123