Cleanup PolygonPessimisticConsensus 1 #575
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrevuelta
commented
Nov 25, 2025
| /* eslint-disable no-unsafe-optional-chaining */ | ||
| /* eslint-disable @typescript-eslint/no-unused-expressions */ | ||
| /* eslint-disable @typescript-eslint/no-use-before-define */ | ||
| /* eslint-disable no-plusplus, no-await-in-loop */ |
Collaborator
Author
There was a problem hiding this comment.
Some things re this file:
- The diff is missleading. I havent added code, just removed. And some very very minor renaming and changes.
- To avoid more complexity in here, leaving this as TODO. This file is named
UpgradeToPPbut there is ashould create rollup type validium & migrate to ALGatewaytest. I guess that test doesn't belong here. If so, will move it in a different PR.
alrevuelta
commented
Nov 25, 2025
|
|
||
| describe('Polygon Rollup Manager with Polygon Pessimistic Consensus', () => { | ||
|
|
||
| describe('Polygon Rollup Manager with zkevm etrog migration to ECDSA Multisig with real prover', () => { |
Collaborator
Author
There was a problem hiding this comment.
Renamed this, since this test contains migration zkevm etroc to ECDSA as well, not just to PP.
alrevuelta
commented
Nov 25, 2025
| await polTokenContract.transfer(trustedSequencer, ethers.parseEther('1000')); | ||
| }); | ||
|
|
||
| it('should check the initialized parameters', async () => { |
Collaborator
Author
There was a problem hiding this comment.
I have removed this logic since it is already tested here: https://github.com/agglayer/agglayer-contracts/blob/feature/v12/test/contractsv2/PolygonRollupManager.test.ts#L225-L256 It was a copy paste, so no need to be duplicated.
alrevuelta
requested review from
ignasirv,
invocamanman,
krlosMata and
laisolizq
as code owners
alrevuelta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a series of multiple PRs cleaning up the legacy
PolygonPessimisticConsensus. All code referencing such feature is removed. This can be done since there are noPolygonPessimisticConsensusdeployed in any chain (mainnet, testnets, etc), no migrations to/fromPolygonPessimisticConsensusare expected in the future and no new deployment with such types will happen in the future.Since the changes are rather big for a single PR, more PRs will follow up addressing the following in parts:
NOTE: Do not merge this PR until feature/v13 branch is created.