Skip to content

feat: last L2 block in certificate sanity check on aggsender-validator #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 13, 2025
Merged

feat: last L2 block in certificate sanity check on aggsender-validator #863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9fadd2a
feat: add sanity check
goran-ethernal Aug 12, 2025
289ad89
feat: UTs
goran-ethernal Aug 12, 2025
aa01492
fix: change CalculateCertificateType
goran-ethernal Aug 12, 2025
c26ec0f
fix: comments
goran-ethernal Aug 13, 2025
24fc747
fix: comment
goran-ethernal Aug 13, 2025
2bdd48e
fix: UT
goran-ethernal Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions aggsender/mocks/mock_aggchain_fep_rollup_querier.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

148 changes: 126 additions & 22 deletions aggsender/mocks/mock_certificate_querier.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions aggsender/query/aggchain_fep_rollup_query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ func (n *noOpAggchainFEPRollupQuerier) GetLastSettledL2Block() (uint64, error) {
return 0, nil
}

func (n *noOpAggchainFEPRollupQuerier) IsFEP() bool {
return false
}

var _ types.AggchainFEPRollupQuerier = (*aggchainFEPRollupQuerier)(nil)

// aggchainFEPRollupQuerier encapsulates the necessary information and interfaces required to query
Expand Down Expand Up @@ -94,6 +98,11 @@ func newAggchainFEPQuerier(
}, nil
}

// IsFEP returns true if the AggchainFEP querier is for FEP networks, false otherwise.
func (a *aggchainFEPRollupQuerier) IsFEP() bool {
return true
}

// StartL2Block returns the starting L2 block number for the FEP network.
func (a *aggchainFEPRollupQuerier) StartL2Block() uint64 {
return a.startL2BlockNum
Expand Down
Loading
Loading