fix: claim calldata tests #601
Open
+44
−178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
joanestebanr
approved these changes
Jun 9, 2025
goran-ethernal
approved these changes
Jun 10, 2025
Stefan-Ethernal
approved these changes
Jun 24, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During an audit review, it was identified that several TestClaimCalldata cases were using identical MainnetExitRoot, RollupExitRoot, ProofLocalExitRoot, ProofRollupExitRoot, DestinationNetwork, Metadata, and—critically—GlobalExitRoot for multiple “reverted” and “non-reverted” claims. Because all three expectedClaim structs shared the same exit roots and hence produced identical ABI‐encoded calldata, these tests could not detect whether the code under test was mistakenly grabbing calldata from a reverted transaction instead of a successful one. In other words, if the debug tracer returned the calldata for the reverted claim rather than the non‐reverted claim, the test would still pass—because both claim calls were identical after encoding.