Skip to content

fix: multi chains (2 chains) pessimistic proof e2e tests #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 22, 2025
Merged

fix: multi chains (2 chains) pessimistic proof e2e tests #1024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5d99bcc
remove setting gas price explicitly when claiming
Stefan-Ethernal Sep 18, 2025
a7b8119
use latest kurtosis cdk ref and renames in e2e tests
Stefan-Ethernal Sep 18, 2025
6b03f8b
consistent logging in the bridge service helpers
Stefan-Ethernal Sep 18, 2025
95a5466
switch to latest block finality in l2 bridge syncer
Stefan-Ethernal Sep 18, 2025
2d744eb
reorder block_finality code
Stefan-Ethernal Sep 18, 2025
4723ce3
fix the log when printing the block finality
Stefan-Ethernal Sep 18, 2025
41c8055
rename e2e test suites
Stefan-Ethernal Sep 18, 2025
5156498
fix logging in e2e tests
Stefan-Ethernal Sep 19, 2025
d811993
revert enclave renamings
Stefan-Ethernal Sep 19, 2025
ed871da
print the merged kurtosis configs
Stefan-Ethernal Sep 19, 2025
7792106
renames in test-e2e
Stefan-Ethernal Sep 19, 2025
afddc3e
remove is_vanilla_client param
Stefan-Ethernal Sep 19, 2025
fa49db2
bump kurtosis cdk (fix multi chain e2e tests hopefully)
Stefan-Ethernal Sep 22, 2025
14a6687
rename the base args file
Stefan-Ethernal Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/test_e2e_cdk_args_base.json → .github/test_e2e_args_base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"args": {
"consensus_contract_type": "ecdsa_multisig",
"use_agg_sender_validator": true,
"is_vanilla_client": true,
"agg_sender_validator_total_number": 3,
"agg_sender_multisig_threshold": 2,
"l1_seconds_per_slot": 2,
Expand Down
135 changes: 71 additions & 64 deletions .github/workflows/test-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
fi
else
# For push/workflow_dispatch, use the fixed commit
COMMIT="07908af1ac5cb13e676319ee65ae5c20449010ac"
COMMIT="ce9630dcef1d8df6a8ec929ae1cd6bb4dad9f889"
echo "Using fixed kurtosis-cdk commit: ${COMMIT}"
fi
echo "commit=${COMMIT}" >> $GITHUB_OUTPUT
Expand All @@ -73,8 +73,8 @@ jobs:
kurtosis-cdk-args-single-op-succinct: ${{ steps.read-args.outputs.op_succinct_args }}
# single l2 network (op-succinct with aggoracle committee)
kurtosis-cdk-args-single-op-succinct-aggoracle-committee: ${{ steps.read-args.outputs.op_succinct_aggoracle_committee_args }}
# single l2 network (fork 12, pessimistic)
kurtosis-cdk-args-single-fork12-pessimistic: ${{ steps.read-args.outputs.fork12_pessimistic_args }}
# single l2 network (op, pessimistic)
kurtosis-cdk-args-single-op-pessimistic: ${{ steps.read-args.outputs.single_op_chain_pessimistic_args }}
# single l2 network (fork 12, global index pp old contracts)
kurtosis-cdk-args-single-fork12-global-index-pp-old-contracts: ${{ steps.read-args.outputs.fork12_global_index_pp_old_contracts_args }}
# multi l2 networks
Expand All @@ -90,36 +90,43 @@ jobs:
- name: Read kurtosis-cdk-args from file
id: read-args
run: |
BASE_CONTENT=$(cat ./.github/test_e2e_cdk_args_base.json | jq -c .)
BASE=./.github/test_e2e_args_base.json

# Helper: merge base with override (if any), output to GITHUB_OUTPUT, and pretty print
put_args() {
local name="$1"
local override="$2"
local content

if [ -n "$override" ]; then
content=$(jq -s '.[0] * .[1]' "$BASE" "$override" | jq -c .)
else
content=$(jq -c . "$BASE")
fi

echo "${name}=${content}" >> "$GITHUB_OUTPUT"
echo "### $name"
echo "$content" | jq .
}

# single l2 network (fork 12, op-succinct)
CONTENT=$(cat ./.github/test_e2e_single_chain_op_succinct_args.json | jq -c .)
echo "op_succinct_args=${CONTENT}" >> $GITHUB_OUTPUT
put_args op_succinct_args ./.github/test_e2e_single_chain_op_succinct_args.json

# single l2 network (fork 12, op-succinct with aggoracle committee)
CONTENT=$(cat ./.github/test_e2e_single_chain_op_succinct_aggoracle_committee_args.json | jq -c .)
echo "op_succinct_aggoracle_committee_args=${CONTENT}" >> $GITHUB_OUTPUT
# single l2 network (fork 12, pessimistic)
echo "fork12_pessimistic_args=${BASE_CONTENT}" >> $GITHUB_OUTPUT
put_args op_succinct_aggoracle_committee_args ./.github/test_e2e_single_chain_op_succinct_aggoracle_committee_args.json

# single l2 network (op, pessimistic)
put_args single_op_chain_pessimistic_args

# single l2 network (fork 12, global index pp old contracts)
CONTENT=$(jq -s '.[0] * .[1]' ./.github/test_e2e_cdk_args_base.json ./.github/test_e2e_cdk_args_global_index_pp_old_contracts.json | jq -c .)
echo "fork12_global_index_pp_old_contracts_args=${CONTENT}" >> $GITHUB_OUTPUT
put_args fork12_global_index_pp_old_contracts_args ./.github/test_e2e_cdk_args_global_index_pp_old_contracts.json

# multi l2 networks
echo "kurtosis-cdk-args-1=${BASE_CONTENT}" >> $GITHUB_OUTPUT
CONTENT=$(jq -s 'reduce .[] as $item ({}; . * $item)' \
./.github/test_e2e_cdk_args_base.json \
./.github/test_e2e_multi_chains_args_2.json | jq -c .)
echo "kurtosis-cdk-args-2=${CONTENT}" >> $GITHUB_OUTPUT
# Merge base_1 args with args_3 for kurtosis-cdk-args-3
echo "kurtosis-cdk-args-3=${BASE_CONTENT}" >> $GITHUB_OUTPUT
# Merge base_2 args with args_4 for kurtosis-cdk-args-4
CONTENT=$(jq -s 'reduce .[] as $item ({}; . * $item)' \
./.github/test_e2e_cdk_args_base.json \
./.github/test_e2e_multi_chains_args_2.json | jq -c .)
echo "kurtosis-cdk-args-4=${CONTENT}" >> $GITHUB_OUTPUT
# Merge base_2 args with args_5 for kurtosis-cdk-args-5
CONTENT=$(jq -s 'reduce .[] as $item ({}; . * $item)' \
./.github/test_e2e_cdk_args_base.json \
./.github/test_e2e_multi_chains_args_3.json | jq -c .)
echo "kurtosis-cdk-args-5=${CONTENT}" >> $GITHUB_OUTPUT
put_args kurtosis-cdk-args-1
put_args kurtosis-cdk-args-2 ./.github/test_e2e_multi_chains_args_2.json
put_args kurtosis-cdk-args-3
put_args kurtosis-cdk-args-4 ./.github/test_e2e_multi_chains_args_2.json
put_args kurtosis-cdk-args-5 ./.github/test_e2e_multi_chains_args_3.json

build-tools:
name: Build aggsender find imported bridge tool
Expand All @@ -141,30 +148,30 @@ jobs:
name: aggsender_find_imported_bridge
path: ./target/aggsender_find_imported_bridge

test-single-l2-network-fork12-pessimistic:
name: Single L2 chain tests (pessimistic)
test-single-l2-network-op-pessimistic:
name: Single L2 chain tests (OP, pessimistic)
needs:
- build-aggkit-image
- read-aggkit-args
- get-kurtosis-cdk-commit
uses: agglayer/e2e/.github/workflows/aggkit-e2e-single-chain.yml@9ce0639b4cfaff71895e0e04d59b96911c2c8660
uses: agglayer/e2e/.github/workflows/aggkit-e2e-single-chain.yml@d000ca0a0bfcfa15db77468621f561763f1403ef
secrets: inherit
with:
kurtosis-cdk-ref: ${{ needs.get-kurtosis-cdk-commit.outputs.kurtosis-commit }}
agglayer-e2e-ref: 9ce0639b4cfaff71895e0e04d59b96911c2c8660
agglayer-e2e-ref: d000ca0a0bfcfa15db77468621f561763f1403ef
kurtosis-cdk-enclave-name: aggkit
kurtosis-cdk-args: ${{ needs.read-aggkit-args.outputs.kurtosis-cdk-args-single-fork12-pessimistic }}
test-name: "test-single-l2-network-fork12-pessimistic"
kurtosis-cdk-args: ${{ needs.read-aggkit-args.outputs.kurtosis-cdk-args-single-op-pessimistic }}
test-name: "test-single-l2-network-op-pessimistic"
event-name: ${{ github.event_name }}

check-single-l2-network-fork12-pessimistic-tests-result:
name: Check results for single l2 network (pessimistic)
name: Check results for single l2 network (OP, pessimistic)
needs:
- test-single-l2-network-fork12-pessimistic
- test-single-l2-network-op-pessimistic
runs-on: ubuntu-latest
steps:
- run: exit 1
if: ${{ contains(fromJSON('["failure", "cancelled"]'), needs.test-single-l2-network-fork12-pessimistic.result) }}
if: ${{ contains(fromJSON('["failure", "cancelled"]'), needs.test-single-l2-network-op-pessimistic.result) }}

test-single-l2-network-fork12-global-index-pp-old-contracts:
name: Single L2 chain tests (global index pp old contracts)
Expand All @@ -173,12 +180,12 @@ jobs:
- build-tools
- read-aggkit-args
- get-kurtosis-cdk-commit
uses: agglayer/e2e/.github/workflows/aggkit-e2e-single-chain.yml@9ce0639b4cfaff71895e0e04d59b96911c2c8660
uses: agglayer/e2e/.github/workflows/aggkit-e2e-single-chain.yml@d000ca0a0bfcfa15db77468621f561763f1403ef
secrets: inherit
if: always() && github.event_name == 'schedule' && github.ref == 'refs/heads/develop'
with:
kurtosis-cdk-ref: ${{ needs.get-kurtosis-cdk-commit.outputs.kurtosis-commit }}
agglayer-e2e-ref: 9ce0639b4cfaff71895e0e04d59b96911c2c8660
agglayer-e2e-ref: d000ca0a0bfcfa15db77468621f561763f1403ef
kurtosis-cdk-enclave-name: aggkit
kurtosis-cdk-args: ${{ needs.read-aggkit-args.outputs.kurtosis-cdk-args-single-fork12-global-index-pp-old-contracts }}
test-name: "test-single-l2-network-fork12-global-index-pp-old-contracts"
Expand All @@ -201,11 +208,11 @@ jobs:
- build-aggkit-image
- read-aggkit-args
- get-kurtosis-cdk-commit
uses: agglayer/e2e/.github/workflows/aggkit-e2e-single-chain.yml@9ce0639b4cfaff71895e0e04d59b96911c2c8660
uses: agglayer/e2e/.github/workflows/aggkit-e2e-single-chain.yml@d000ca0a0bfcfa15db77468621f561763f1403ef
secrets: inherit
with:
kurtosis-cdk-ref: ${{ needs.get-kurtosis-cdk-commit.outputs.kurtosis-commit }}
agglayer-e2e-ref: 9ce0639b4cfaff71895e0e04d59b96911c2c8660
agglayer-e2e-ref: d000ca0a0bfcfa15db77468621f561763f1403ef
kurtosis-cdk-enclave-name: op
kurtosis-cdk-args: ${{ needs.read-aggkit-args.outputs.kurtosis-cdk-args-single-op-succinct }}
test-name: "test-single-l2-network-op-succinct"
Expand All @@ -226,12 +233,12 @@ jobs:
- build-aggkit-image
- read-aggkit-args
- get-kurtosis-cdk-commit
uses: agglayer/e2e/.github/workflows/aggkit-e2e-single-chain.yml@9ce0639b4cfaff71895e0e04d59b96911c2c8660
uses: agglayer/e2e/.github/workflows/aggkit-e2e-single-chain.yml@d000ca0a0bfcfa15db77468621f561763f1403ef
secrets: inherit
if: always() && github.event_name == 'schedule' && github.ref == 'refs/heads/develop'
with:
kurtosis-cdk-ref: ${{ needs.get-kurtosis-cdk-commit.outputs.kurtosis-commit }}
agglayer-e2e-ref: 9ce0639b4cfaff71895e0e04d59b96911c2c8660
agglayer-e2e-ref: d000ca0a0bfcfa15db77468621f561763f1403ef
kurtosis-cdk-enclave-name: op
kurtosis-cdk-args: ${{ needs.read-aggkit-args.outputs.kurtosis-cdk-args-single-op-succinct-aggoracle-committee }}
test-name: "test-single-l2-network-op-succinct-aggoracle-committee"
Expand All @@ -247,45 +254,45 @@ jobs:
- run: exit 1
if: ${{ contains(fromJSON('["failure", "cancelled"]'), needs.test-single-l2-network-op-succinct-aggoracle-committee.result) }}

test-multi-l2-networks-2-chains:
name: Multi chains E2E test (2 chains)
test-multi-l2-networks-2-chains-op-pessimistic:
name: Multi chains E2E tests (OP, pessimistic, 2 chains)
needs:
- build-aggkit-image
- build-tools
- read-aggkit-args
- get-kurtosis-cdk-commit
uses: agglayer/e2e/.github/workflows/aggkit-e2e-multi-chains.yml@9ce0639b4cfaff71895e0e04d59b96911c2c8660
uses: agglayer/e2e/.github/workflows/aggkit-e2e-multi-chains.yml@d000ca0a0bfcfa15db77468621f561763f1403ef
secrets: inherit
with:
kurtosis-cdk-ref: ${{ needs.get-kurtosis-cdk-commit.outputs.kurtosis-commit }}
agglayer-e2e-ref: 9ce0639b4cfaff71895e0e04d59b96911c2c8660
agglayer-e2e-ref: d000ca0a0bfcfa15db77468621f561763f1403ef
kurtosis-cdk-enclave-name: aggkit
aggsender-find-imported-bridge-artifact: aggsender_find_imported_bridge
kurtosis-cdk-args-1: ${{ needs.read-aggkit-args.outputs.kurtosis-cdk-args-1 }}
kurtosis-cdk-args-2: ${{ needs.read-aggkit-args.outputs.kurtosis-cdk-args-2 }}

check-multi-l2-networks-2-chains-tests-result:
name: Check results for multi l2 networks (2 chains)
name: Check results for multi l2 networks (OP, pessimistic, 2 chains)
needs:
- test-multi-l2-networks-2-chains
- test-multi-l2-networks-2-chains-op-pessimistic
runs-on: ubuntu-latest
steps:
- run: exit 1
if: ${{ contains(fromJSON('["failure", "cancelled"]'), needs.test-multi-l2-networks-2-chains.result) }}
if: ${{ contains(fromJSON('["failure", "cancelled"]'), needs.test-multi-l2-networks-2-chains-op-pessimistic.result) }}

test-multi-l2-networks-3-chains:
name: Multi chains E2E test (3 chains)
test-multi-l2-networks-3-chains-op-pessimistic:
name: Multi chains E2E tests (OP, pessimistic, 3 chains)
needs:
- build-aggkit-image
- build-tools
- read-aggkit-args
- get-kurtosis-cdk-commit
uses: agglayer/e2e/.github/workflows/aggkit-e2e-multi-chains.yml@9ce0639b4cfaff71895e0e04d59b96911c2c8660
uses: agglayer/e2e/.github/workflows/aggkit-e2e-multi-chains.yml@d000ca0a0bfcfa15db77468621f561763f1403ef
secrets: inherit
if: always() && github.event_name == 'schedule' && github.ref == 'refs/heads/develop'
with:
kurtosis-cdk-ref: ${{ needs.get-kurtosis-cdk-commit.outputs.kurtosis-commit }}
agglayer-e2e-ref: 9ce0639b4cfaff71895e0e04d59b96911c2c8660
agglayer-e2e-ref: d000ca0a0bfcfa15db77468621f561763f1403ef
kurtosis-cdk-enclave-name: aggkit
aggsender-find-imported-bridge-artifact: aggsender_find_imported_bridge
kurtosis-cdk-args-1: ${{ needs.read-aggkit-args.outputs.kurtosis-cdk-args-3 }}
Expand All @@ -294,23 +301,23 @@ jobs:
number-of-chains: 3

check-multi-l2-networks-3-chains-tests-result:
name: Check results for multi l2 networks (3 chains)
name: Check results for multi l2 networks (OP, pessimisstic, 3 chains)
needs:
- test-multi-l2-networks-3-chains
- test-multi-l2-networks-3-chains-op-pessimistic
runs-on: ubuntu-latest
if: always() && github.event_name == 'schedule' && github.ref == 'refs/heads/develop'
steps:
- run: exit 1
if: ${{ contains(fromJSON('["failure", "cancelled"]'), needs.test-multi-l2-networks-3-chains.result) }}
if: ${{ contains(fromJSON('["failure", "cancelled"]'), needs.test-multi-l2-networks-3-chains-op-pessimistic.result) }}

notify-slack:
name: Notify Slack
needs:
- test-single-l2-network-fork12-pessimistic
- test-single-l2-network-op-pessimistic
Copy link
Contributor

@temaniarpit27 temaniarpit27 Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we replacing cdk with op?

Copy link
Contributor Author

@Stefan-Ethernal Stefan-Ethernal Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To provide you with the context:

  • we are deprecating the PolygonPessimisticConsensus (and all the legacy rollup implementations AFAIK), in favor of AggchainECDSAMultisig (PP certificates) and AggchainFEP (FEP certificates),
  • kurtosis cdk was not supporting the cdk erigon as the L2, up until two days ago, and the op-stack was the only option we had for running pessimistic proofs (that's why we have chosen to integrate this part into the CI first). After this PR, I'm going to start integrating the cdk erigon path as well,
  • probably it is enough to have only single chain tests running against the cdk erigon setup. IMO it is better that way, because op-stack acts as the vanilla client.

- test-single-l2-network-op-succinct
- test-single-l2-network-op-succinct-aggoracle-committee
- test-multi-l2-networks-2-chains
- test-multi-l2-networks-3-chains
- test-multi-l2-networks-2-chains-op-pessimistic
- test-multi-l2-networks-3-chains-op-pessimistic
- test-single-l2-network-fork12-global-index-pp-old-contracts
- get-kurtosis-cdk-commit
runs-on: ubuntu-latest
Expand All @@ -327,11 +334,11 @@ jobs:
Kurtosis CDK Commit: `${{ needs.get-kurtosis-cdk-commit.outputs.kurtosis-commit }}`

Test Results:
• Single L2 (pessimistic): ${{ needs.test-single-l2-network-fork12-pessimistic.result == 'success' && '🟢' || '🔴' }}
• Single L2 (OP, pessimistic): ${{ needs.test-single-l2-network-op-pessimistic.result == 'success' && '🟢' || '🔴' }}
• Single L2 (op-succinct): ${{ needs.test-single-l2-network-op-succinct.result == 'success' && '🟢' || '🔴' }}
• Single L2 (op-succinct with aggoracle committee): ${{ needs.test-single-l2-network-op-succinct-aggoracle-committee.result == 'success' && '🟢' || '🔴' }}
• Multi L2 (2 chains): ${{ needs.test-multi-l2-networks-2-chains.result == 'success' && '🟢' || '🔴' }}
• Multi L2 (3 chains): ${{ needs.test-multi-l2-networks-3-chains.result == 'success' && '🟢' || '🔴' }}
• Multi L2 (OP, pessimistic, 2 chains): ${{ needs.test-multi-l2-networks-2-chains-op-pessimistic.result == 'success' && '🟢' || '🔴' }}
• Multi L2 (OP, pessimistic, 3 chains): ${{ needs.test-multi-l2-networks-3-chains-op-pessimistic.result == 'success' && '🟢' || '🔴' }}
• Single L2 (global index pp old contracts): ${{ needs.test-single-l2-network-fork12-global-index-pp-old-contracts.result == 'success' && '🟢' || '🔴' }}

<${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|View Workflow>
2 changes: 1 addition & 1 deletion sync/evmdownloader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func NewEVMDownloader(
}

logger.Infof("downloader initialized with block finality: %s, finalized block type: %s. SyncChunkSize: %d",
finality, fbtEthermanType, syncBlockChunkSize)
finality.String(), fbtEthermanType.String(), syncBlockChunkSize)

return &EVMDownloader{
syncBlockChunkSize: syncBlockChunkSize,
Expand Down
Loading
Loading