DRAFT: FreePointed for comparison
#1963
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmckinna
added
addition
status: blocked-by-issue
JacquesCarette
approved these changes
May 4, 2023
|
The reason for the exercise was to show just how deeply the cut-and-paste goes. |
|
I'll close this for now, but potentially re-open it once:
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. #1954 / #1962 and @JacquesCarette 's request for comparison. See also issue #1957 for blocking dependencies.
Besides library design issues, the only real difference is that of the arity (0, rather than 2) of the
ptconstructor, and hence also of thecong/homoproperties of the associatedIs*Homomorphismrecords. Otherwise, it was pure cut-and-paste, modulo the additional infrastructure forIdentityandCompositionforIsPointedHomomorphism.