Fast binary conversion #1495
Merged
Fast binary conversion #1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewDaggitt
requested changes
May 6, 2021
There was a problem hiding this comment.
Thank you for the awesome PR! I've added some comments, and moved fromN-helper method inside a local where module to limit it's outside exposure and make it clear that it's not supposed to be used on it's own.
Apart from the comments, the only other thing is to add CHANGELOG entries for any new proofs you've added.
|
Thank you for the prompt and useful feedback @MatthewDaggitt. I've been through and resolved all of your comments, all very sensible suggestions! |
MatthewDaggitt
approved these changes
May 10, 2021
|
Great thanks for the changes. I'll leave it up a couple more days to see if anyone else has any comments, and then I'll merge it in. Thanks again for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes @oisdk's approach from the discussion in #1405 and cleans it up a bit, trying to integrate better with other parts of stdlib.
Feedback welcome, especially if there are other proofs in stdlib that could support in
fromℕ-helper≡fromℕ'.Closes #1468.