-
Notifications
You must be signed in to change notification settings - Fork 260
Changes related to a change to Agda's reflection machinery. #1480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MatthewDaggitt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I did not write anything in the changelog.
I think the changes do need to be documented, a brief description of the new changes/modules + a pointer to the Agda 2.6.2 CHANGELOG?
I did not add any deprecation warnings.
I think that's fine. The reflection API is undergoing a lot of churn at the moment, I don't think it's feasible to hide it from the user.
I changed the semantics of Tactic.RingSolver.Core.ReflectionHelp.getVisible.
That doesn't need to be documented as it's in a Core module which we do not guarantee the backwards compatibility for.
The function showTerm does not print erasure annotations (but it also does not print relevance annotations).
That would be good to fix while we're here! It should be pretty easy right?
The reflection machinery now supports erasure (in Arg), see agda/agda#5317. Note that the function showTerm does not print erasure annotations. However, it also does not print relevance annotations.
My idea was to leave this to you, so that you get things the way you want them. However, I've written something now.
I don't want to spend time adding features to the standard library right now. I think I've addressed your other remarks. |
|
Opened #1491 for the printing of argument annotations. |
The reflection machinery now supports erasure (in Arg), see agda/agda#5317.
I made the code compile, but further changes may be warranted:
I did not write anything in the changelog.
I did not add any deprecation warnings.
I changed the semantics of
Tactic.RingSolver.Core.ReflectionHelp.getVisible.The function
showTermdoes not print erasure annotations (but it also does not print relevance annotations).