Skip to content

Conversation

@nad
Copy link
Contributor

@nad nad commented Apr 16, 2021

The reflection machinery now supports erasure (in Arg), see agda/agda#5317.

I made the code compile, but further changes may be warranted:

  • I did not write anything in the changelog.

  • I did not add any deprecation warnings.

  • I changed the semantics of Tactic.RingSolver.Core.ReflectionHelp.getVisible.

  • The function showTerm does not print erasure annotations (but it also does not print relevance annotations).

@MatthewDaggitt MatthewDaggitt added this to the agda-v2.6.2 milestone Apr 20, 2021
Copy link
Contributor

@MatthewDaggitt MatthewDaggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I did not write anything in the changelog.

I think the changes do need to be documented, a brief description of the new changes/modules + a pointer to the Agda 2.6.2 CHANGELOG?

I did not add any deprecation warnings.

I think that's fine. The reflection API is undergoing a lot of churn at the moment, I don't think it's feasible to hide it from the user.

I changed the semantics of Tactic.RingSolver.Core.ReflectionHelp.getVisible.

That doesn't need to be documented as it's in a Core module which we do not guarantee the backwards compatibility for.

The function showTerm does not print erasure annotations (but it also does not print relevance annotations).

That would be good to fix while we're here! It should be pretty easy right?

The reflection machinery now supports erasure (in Arg), see
agda/agda#5317.

Note that the function showTerm does not print erasure annotations.
However, it also does not print relevance annotations.
@nad
Copy link
Contributor Author

nad commented Apr 20, 2021

I think the changes do need to be documented, a brief description of the new changes/modules + a pointer to the Agda 2.6.2 CHANGELOG?

My idea was to leave this to you, so that you get things the way you want them. However, I've written something now.

The function showTerm does not print erasure annotations (but it also does not print relevance annotations).

That would be good to fix while we're here! It should be pretty easy right?

I don't want to spend time adding features to the standard library right now. I think I've addressed your other remarks.

@MatthewDaggitt
Copy link
Contributor

Opened #1491 for the printing of argument annotations.

@MatthewDaggitt MatthewDaggitt merged commit 94fd103 into experimental Apr 27, 2021
@MatthewDaggitt MatthewDaggitt deleted the issue5317 branch April 27, 2021 02:47
@MatthewDaggitt MatthewDaggitt modified the milestones: agda-v2.6.2, v1.7 May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reflection upstream Changes induced by Agda upstream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants