feat(122, oas): clarify parent field usage #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toumorokoshi
force-pushed
the
yft/clarify-122
branch
3 times, most recently
from
fed3a4c to
af11ea8
Compare
AEP-122 only has guidance on the parent path for proto. Adding OAS guidance to reduce confusion. Fixes aep-dev#325
toumorokoshi
force-pushed
the
yft/clarify-122
branch
from
af11ea8 to
370075d
Compare
rambleraptor
reviewed
Sep 2, 2025
Member
rambleraptor
left a comment
rambleraptor
left a comment
There was a problem hiding this comment.
What would you think about moving the part about extracting parent from URI outside of the OAS section?
The only true OAS guidance is that a parent field isn't required compared to proto
Member
Author
@thegagne do you have an opinion? i generally have been adding more information to clarify questions for consumers. I think these types of patterns should be documented somewhere, but I could put it in a section farther down, possibly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AEP-122 only has guidance on the parent path for proto. Adding OAS guidance to reduce confusion.
Fixes #325
🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for
contributing to this repository.
General
references AEPs
correctly.
(usually
prettier -w .)💝 Thank you!