Implement TemplateStatefulSet function #278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
factory.TemplateStatefulSetfunction. The templating was originally carried out as part of thefactory.CreateOrUpdateStatefulSetfunction. Almost all of the templating is branchless and is mostly inlined inside of a struct literal. References to thePodTemplatefield of theEtcdCluster.Specstruct were dropped, as premature features that for now only complicate the code, while being non-essential to operating an etcd cluster. When needed, parts of the statefulset template can be factored back out into separate helper functions, much like is already done in e.g.factory.volumes()and the possibility of customizing the etcd pod with custom annotations, labels, sidecar containers, etc. can be restored.