rename internal package

[adriangb]

No description provided.

[adriangb]

Hi @messense , sorry to bother you, do you see any obvious reason why this would be failing in CI? It runs for me locally even after a git clean -fdx.

[messense]

I think it's because Python try to import the local one first, see PyO3/maturin#490.

I'd keep the python/ folder to avoid such problem, the internal module rename should be fine.

[messense]

It's the exact reason we changed the default template to include a python folder in PyO3/maturin#855

[messense]

😅 There was a bug when package.metadata.maturin.name and python-source are both set and name contains dot, I think I've fixed it in https://github.com/PyO3/maturin/pull/969/files#diff-87a24e61912b4f23e30d6031f5adc136adfa6008772880ae53a355cedfaee466R104

You can try 0.13.0-beta.6 when it's out.

[adriangb]

Thanks yeah that's why I originally switched the layout

[messense]

We haven't implement reading maturin version from pyproject.toml in maturin-action yet, so you need to specify it manually:

- uses: messense/maturin-action@v1
  with:
    maturin-version: v0.13.0-beta.6

[messense]

There were some breaking changes in v0.13, --no-sdist is replaced by --sdist, see PyO3/maturin#955

[adriangb]

Thank you @messense !