Skip to content

Conversation

@MattyWeee123
Copy link
Contributor

@MattyWeee123 MattyWeee123 commented Jul 21, 2025

metricConfig2JSON.py parses and rearranges BenchmarkMetrics.js into JSON. initBenchmarkMetrics.py generates templates for a groovy aggregate metric map and a single test map for archiving individual test/baseline child jobs. benchmarkMetrics.py updates a single test map with the metric value for a run.

testList is used to generalize regression monitoring and EXIT_EARLY for child jobs that run multiple tests (removing from testList will have both parent and child ignore the removed test).

Using specific rhel9 machine to run the python scripts and getPythonDependencies uses curl to retrieve the relevant python scripts.

BenchmarkMetric.js needs to be updated (lusearch-fix should be lusearch, tomcat is not there so the script thinks it should grab all dacapo metrics for tomcat which is not true, ...)

Fixes: #6418, #6355

metricConfig2JSON.py parses and rearranges BenchmarkMetrics.js into JSON.
initBenchmarkMetrics.py generates templates for a groovy aggregate metric
map and a single test map for archiving individual test/baseline child jobs.
benchmarkMetrics.py updates a single test map with the metric value for a run.

testList is used to generalize regression monitoring and EXIT_EARLY for
child jobs that run multiple tests (removing from testList will have both
parent and child ignore the removed test).

Using specific rhel9 machine to run the python scripts and getPythonDependencies
uses curl to retrieve the relevant python scripts.

Fixes: adoptium#6418, adoptium#6355

Signed-off-by: Matthew Wei <[email protected]>
@MattyWeee123 MattyWeee123 marked this pull request as ready for review July 21, 2025 18:24
@karianna karianna requested a review from llxia July 22, 2025 02:10
@llxia
Copy link
Contributor

llxia commented Jul 28, 2025

Thanks @MattyWeee123 . Have you tried to run this in https://ci.adoptium.net/view/Test_grinder/job/Perf_Pipeline/? If so, please provide the link. Thanks

@MattyWeee123
Copy link
Contributor Author

@karianna karianna requested a review from llxia July 29, 2025 04:46
@karianna
Copy link
Contributor

@MattyWeee123 Will need a rebase (or that merge conflict fixed)

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MattyWeee123

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

L3 is non-unique to Perf Pipeline, move all logic related to generating benchmark metrics and checking for regression to L2

3 participants