-
-
Notifications
You must be signed in to change notification settings - Fork 335
Generalized regression monitoring for PerfPipeline. #6443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
metricConfig2JSON.py parses and rearranges BenchmarkMetrics.js into JSON. initBenchmarkMetrics.py generates templates for a groovy aggregate metric map and a single test map for archiving individual test/baseline child jobs. benchmarkMetrics.py updates a single test map with the metric value for a run. testList is used to generalize regression monitoring and EXIT_EARLY for child jobs that run multiple tests (removing from testList will have both parent and child ignore the removed test). Using specific rhel9 machine to run the python scripts and getPythonDependencies uses curl to retrieve the relevant python scripts. Fixes: adoptium#6418, adoptium#6355 Signed-off-by: Matthew Wei <[email protected]>
… next test; only remove from list if no regression is found across all metrics
|
Thanks @MattyWeee123 . Have you tried to run this in https://ci.adoptium.net/view/Test_grinder/job/Perf_Pipeline/? If so, please provide the link. Thanks |
…ther one has issues finding python3
|
@MattyWeee123 Will need a rebase (or that merge conflict fixed) |
llxia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MattyWeee123
karianna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicks :-)
838b5aa to
f0c6043
Compare
metricConfig2JSON.py parses and rearranges BenchmarkMetrics.js into JSON. initBenchmarkMetrics.py generates templates for a groovy aggregate metric map and a single test map for archiving individual test/baseline child jobs. benchmarkMetrics.py updates a single test map with the metric value for a run.
testList is used to generalize regression monitoring and EXIT_EARLY for child jobs that run multiple tests (removing from testList will have both parent and child ignore the removed test).
Using specific rhel9 machine to run the python scripts and getPythonDependencies uses curl to retrieve the relevant python scripts.
BenchmarkMetric.js needs to be updated (lusearch-fix should be lusearch, tomcat is not there so the script thinks it should grab all dacapo metrics for tomcat which is not true, ...)
Fixes: #6418, #6355