Skip to content

fix: add null checks for window.__swc.warn in test environments #5870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: add null checks for window.__swc.warn in test environments #5870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 1st-gen/packages/overlay/src/slottable-request-directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export class SlottableRequestDirective extends AsyncDirective {
{ signal }
);

if (window.__swc.DEBUG) {
if (window.__swc?.DEBUG && window.__swc?.warn) {
window.__swc.warn(
undefined,
`⚠️ WARNING ⚠️ : The Overlay Trigger Directive is experimental and there is no guarantees behind its usage in an application!! Its API and presence within the library could be changed at anytime. See "sp-overlay" or "Overlay.open()" for a stable API for overlaying content on your application.`,
Expand Down
2 changes: 1 addition & 1 deletion 1st-gen/packages/overlay/src/slottable-request-event.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export class SlottableRequestEvent extends Event {
this.name = name;
this.data = data;
this.slotName = key !== undefined ? `${name}.${key}` : name;
if (window.__swc.DEBUG) {
if (window.__swc?.DEBUG && window.__swc?.warn) {
window.__swc.warn(
undefined,
`⚠️ WARNING ⚠️ : \`slottable-request\` events are experimental and there is no guarantees behind usage of them in an application!! Their shape and presence within the library could be changed at anytime.
Expand Down
Loading