fix: S2 Tabs collapsing with a single word #8765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
yihuiliao
approved these changes
Aug 22, 2025
Member
yihuiliao
left a comment
yihuiliao
left a comment
There was a problem hiding this comment.
lgtm, would be good to run chromatic just in case
LFDanLu
approved these changes
Aug 22, 2025
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
tested across browsers, collapsing seems to still work well
reidbarber
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When S2 Tabs have only a single word in each tab they would never collapse due to the
min-width: min-content. Setting this to zero fixes the issue. Updated one of the stories to test.