-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: add SelectBoxGroup to chromatic #8760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| position: 'absolute', | ||
| top: 8, | ||
| left: 8, | ||
| insetStart: 8, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noticed that the checkbox was showing up on the wrong side when i added it to chromatic
| /************************************************************************* | ||
| * ADOBE CONFIDENTIAL | ||
| * ___________________ | ||
| /* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just changed this to match how our files do it
| </div> | ||
| ) | ||
| ), | ||
| tags: ['!autodocs'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could either remove this and rely on chromatic or leave this in storybook and remove it from the docs
|
Build successful! 🎉 |
|
gonna add some stuff from the audit to this PR as well |
| import {TextContext} from './Content'; | ||
| import {useSpectrumContextProps} from './useSpectrumContextProps'; | ||
|
|
||
| type ExcludedListBoxProps = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like we were excluding these but maybe they weren't picked up on the tsdiff? anyway, i decided to remove them and just add them directly to the Omit
|
Build successful! 🎉 |
## API Changes
@react-spectrum/s2/@react-spectrum/s2:SelectBox SelectBox {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
- children?: ReactNode
+ children: ReactNode
isDisabled?: boolean
styles?: StylesProp
value: string
}/@react-spectrum/s2:SelectBoxGroup-SelectBoxGroup <T> {
+SelectBoxGroup <T extends {}> {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
autoFocus?: boolean | FocusStrategy
children: ReactNode
- className?: ClassNameOrFunction<ListBoxRenderProps>
defaultSelectedKeys?: 'all' | Iterable<Key>
- dependencies?: ReadonlyArray<any>
disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
- dragAndDropHooks?: DragAndDropHooks<NoInfer<T>>
escapeKeyBehavior?: 'clearSelection' | 'none' = 'clearSelection'
id?: string
isDisabled?: boolean
items?: Iterable<T>
- layout?: 'stack' | 'grid' = 'stack'
- onAction?: (Key) => void
onBlur?: (FocusEvent<Target>) => void
onFocus?: (FocusEvent<Target>) => void
onFocusChange?: (boolean) => void
onSelectionChange?: (Selection) => void
orientation?: Orientation = 'vertical'
- renderEmptyState?: (ListBoxRenderProps) => ReactNode
selectedKeys?: 'all' | Iterable<Key>
- selectionBehavior?: SelectionBehavior = "toggle"
selectionMode?: 'single' | 'multiple' = 'single'
- shouldFocusOnHover?: boolean
shouldFocusWrap?: boolean
shouldSelectOnPressUp?: boolean
slot?: string | null
- style?: StyleOrFunction<ListBoxRenderProps>
styles?: StylesProp
}/@react-spectrum/s2:SelectBoxProps SelectBoxProps {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
- children?: ReactNode
+ children: ReactNode
isDisabled?: boolean
styles?: StylesProp
value: string
}/@react-spectrum/s2:SelectBoxGroupProps SelectBoxGroupProps <T> {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
autoFocus?: boolean | FocusStrategy
children: ReactNode
- className?: ClassNameOrFunction<ListBoxRenderProps>
defaultSelectedKeys?: 'all' | Iterable<Key>
- dependencies?: ReadonlyArray<any>
disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
- dragAndDropHooks?: DragAndDropHooks<NoInfer<T>>
escapeKeyBehavior?: 'clearSelection' | 'none' = 'clearSelection'
id?: string
isDisabled?: boolean
items?: Iterable<T>
- layout?: 'stack' | 'grid' = 'stack'
- onAction?: (Key) => void
onBlur?: (FocusEvent<Target>) => void
onFocus?: (FocusEvent<Target>) => void
onFocusChange?: (boolean) => void
onSelectionChange?: (Selection) => void
orientation?: Orientation = 'vertical'
- renderEmptyState?: (ListBoxRenderProps) => ReactNode
selectedKeys?: 'all' | Iterable<Key>
- selectionBehavior?: SelectionBehavior = "toggle"
selectionMode?: 'single' | 'multiple' = 'single'
- shouldFocusOnHover?: boolean
shouldFocusWrap?: boolean
shouldSelectOnPressUp?: boolean
slot?: string | null
- style?: StyleOrFunction<ListBoxRenderProps>
styles?: StylesProp
} |
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: