Skip to content

fix: scrollIntoView should respect scroll-margin #8715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: scrollIntoView should respect scroll-margin #8715

wants to merge 2 commits into from

Conversation

nwidynski
Copy link
Contributor

@nwidynski nwidynski commented Aug 13, 2025 •
edited
Loading

Closes #8689

This PR adds scroll-margin adherence to our scrollIntoView shim. It also fixes smooth scrolling when offset is mutated bidirectionally by using native scrollTo().

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scrollIntoView should account for scroll-margin of element
1 participant
@nwidynski