rar5 read FHEXTRA_REDIR and expose via RarEntry #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderb
force-pushed
the
pullreq-rar5-redir
branch
2 times, most recently
from
c8683e5 to
0f02064
Compare
NOTE: api user should skip entries where RarEntry.IsRedir is true and not call OpenEntryStream()
coderb
force-pushed
the
pullreq-rar5-redir
branch
from
0f02064 to
226ce34
Compare
Owner
|
This looks good, thanks! This passed tests but are you saying the generic interface needs to change too? |
Contributor
Author
|
I haven't considered that. I am using RarReader.Open() which has proprerty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: api user should skip entries where RarEntry.IsRedir is true and not call OpenEntryStream()