Zip Multipart fix, XZ stream fix, XZ stream support added to zip/zipx #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split archives using SourceStream.cs were not moving on to the next part when a call Read() spanned 2 parts.
XZ stream support added to zip and zipx. (Which are created by WinZip)
The XZ decoder had a bug that was corrupting data sometimes without error. This was noticed when adding the unit test for WinZip27.XZ.zipx. The previous code fails with this zip (2 bytes in the middle of the exe are invalid). The fix was to re-port X86Converter() in BranchExecFilter.cs. I used a version from https://github.com/torvalds/linux/blob/master/lib/xz/xz_dec_bcj.c
I will also submit a PR that adds Zstandard to zip/zipx and 7zip. Currently this uses a 3rd party nuget package, I don't expect it to be merged, but it might serve as a reference.