-
-
Couldn't load subscription status.
- Fork 150
Update partial rendering docs to cover Django 6.0's built-in support #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, it's shaping up well. I have these suggestions.
| @@ -1,3 +1,2 @@ | |||
| django | |||
| django-template-partials | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test the example project with a fresh venv without django-template-partials installed? I think we need to drop template_partials from INSTALLED_APPS, at least:
django-htmx/example/example/settings.py
Line 23 in 5ac0abc
| "template_partials", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I just ran manage.py check command.
I'll run and check.
| Using django-template-partials | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we title this section "Using template partials" and then explain in terms of both django-template-partials and Django 6.0's new feature? I want it to still work for users who haven't upgraded to 6.0, especially since it's not even out yet!
Perhaps explain the 6.0 way, then the differences in django-template-partials: install the app, use {% load partial %} as well, ...
Co-authored-by: Adam Johnson <[email protected]>
for more information, see https://pre-commit.ci
Related to #557