Skip to content

add warranty bit in spot 25 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2018
Merged

add warranty bit in spot 25 #12

merged 2 commits into from
Dec 30, 2018

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Dec 30, 2018

@caternuson
Copy link
Contributor

Interesting. RPF doesn't mention these in their doc. So instead of

uuuuuuuuFMMMCCCCPPPPTTTTTTTTRRRR

it's actually more like (from link in previous comment):

uuuuuuHGFMMMCCCCPPPPTTTTTTTTRRRR

So need to cover potentiality that H or G might be set.

Numbers look good to me.

caternuson
caternuson reviewed Dec 30, 2018
View reviewed changes
Copy link
Contributor

@caternuson caternuson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise looks good.

@ladyada ladyada merged commit ea528db into adafruit:master Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caternuson caternuson caternuson approved these changes

@brennen brennen Awaiting requested review from brennen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladyada @caternuson