Skip to content

Conversation

@gowridurgad
Copy link
Contributor

@gowridurgad gowridurgad commented Jun 20, 2025

Description:

  • This pull request eliminates references to older .NET versions from the repository. It also updates the README to accurately reflect the currently available versions and revises the end-to-end (E2E) tests to align with these changes.
  • Pull the latest version of installer scripts via npm run update-installers.

Related issue:
#645

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@gowridurgad gowridurgad self-assigned this Jun 23, 2025
@gowridurgad gowridurgad marked this pull request as ready for review June 23, 2025 06:46
Copilot AI review requested due to automatic review settings June 23, 2025 06:46
@gowridurgad gowridurgad requested a review from a team as a code owner June 23, 2025 06:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes deprecated .NET versions from installation scripts, updates documentation and CI workflows to target current supported versions (6.0–9.0), and adjusts E2E tests accordingly.

  • Removed “signed” and “validated” quality options from Bash/PowerShell installers and cleaned up obsolete URL sanitization code.
  • Updated README examples and GitHub Actions matrices to reflect .NET 8.0 and 9.0 support.
  • Extended test mappings and E2E workflows to cover .NET 9.0 and removed older version checks.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
externals/install-dotnet.sh Dropped old quality labels, added retry bug workaround, removed URL sanitization helpers.
externals/install-dotnet.ps1 Removed deprecated qualities, stripped obsolete sanitization functions.
tests/verify-dotnet.ps1 Added mapping for "9.0" = "net9.0".
README.md Swapped references from 3.x/5.x to 8.x/9.x in examples and version syntax.
.github/workflows/test-dotnet.yml Updated dotnet-version matrix to ['6.0','7.0','8.0','9.0'].
.github/workflows/e2e-tests.yml Replaced all 2.x/3.x/5.x setup steps with 6.x–9.x, adjusted verify patterns.
Comments suppressed due to low confidence (1)

externals/install-dotnet.sh:1797

  • [nitpick] Casing is inconsistent: the script error lists 'ga' in lowercase but this usage help shows 'GA' uppercase. Normalize casing to avoid confusion (e.g., use lowercase 'ga' everywhere).
            echo "          The possible values are: daily, preview, GA."

@gowridurgad gowridurgad changed the title Remove Support for older .NET Versions Remove Support for older .NET Versions and Update installers scripts Jun 24, 2025
@HarithaVattikuti HarithaVattikuti merged commit 0f55b45 into actions:main Jun 24, 2025
106 checks passed
COMPUTERS-bit pushed a commit to COMPUTERS-bit/setup-dotnet that referenced this pull request Jun 26, 2025
@Frulfump
Copy link

Frulfump commented Aug 4, 2025

.NET 6 is out of support since November 2024 and .NET 7 since May 2024. .NET 6 was removed now from Azure DevOps 6 months after that as that's their policy what's yours?

Would also be good to test with the .NET 10 previews, RC expected next month with GA in November.

(End of Life (or Out of support) is usually the term that's used in the ecosystem.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants